Re: [PATCH v2 0/3] locking/rwsem/x86: Add stack frame dependency for some inline asm

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Josh Poimboeuf <jpoimboe@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 0/3] locking/rwsem/x86: Add stack frame dependency for some inline asm
Date	Thu, 07 Sep 2017 01:10:01 +0200
Message-ID	<umRCh-8qR-3@gated-at.bofh.it> (permalink)
References	<umB4t-5b7-3@gated-at.bofh.it> <umRiV-85i-1@gated-at.bofh.it>
X-Original-To	Miguel Bernal Marin <miguel.bernal.marin@linux.intel.com>
Dmarc-Filter	OpenDMARC Filter v1.3.2 mx1.redhat.com 67FD7883A5
Authentication-Results	ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results	ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jpoimboe@redhat.com
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Disposition	inline
User-Agent	Mutt/1.6.0.1 (2016-04-01)
X-Scanned-By	MIMEDefang 2.79 on 10.5.11.11
X-Greylist	Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 06 Sep 2017 23:05:54 +0000 (UTC)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	30
Organization	linux.* mail to news gateway
X-Original-Cc	Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, Thomas Gleixner <tglx@linutronix.de>, "H . Peter Anvin" <hpa@zytor.com>, linux-kernel@vger.kernel.org, x86@kernel.org
X-Original-Date	Wed, 6 Sep 2017 18:05:47 -0500
X-Original-Message-ID	<20170906230547.mgwjx74m6g7fntif@treble>
X-Original-References	<20170906052613.30058-1-miguel.bernal.marin@linux.intel.com> <20170906224501.11816-1-miguel.bernal.marin@linux.intel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1727813

Show key headers only | View raw

On Wed, Sep 06, 2017 at 05:44:58PM -0500, Miguel Bernal Marin wrote:
> Some warning were showed by objtool using gcc 7.2.0
> 
> kernel/locking/rwsem.o: warning: objtool: up_read()+0x11: call without frame pointer save/setup
> kernel/locking/rwsem.o: warning: objtool: up_write()+0x17: call without frame pointer save/setup
> kernel/locking/rwsem.o: warning: objtool: downgrade_write()+0x22: call without frame pointer save/setup
> 
> which means gcc placed an inline asm function and its call instruction before
> the frame pointer setup.
>  
> This series forces a stack frame to be created before the call instruction
> by listing the stack pointer as an output operand in the inline asm statement.
> 
> Changes in v2:
>   - Update first parameter from _ASM_ADD to '%3' at __downgrade_write()
> 
> Miguel Bernal Marin (3):
>   locking/rwsem/x86: Add stack frame dependency for __up_read()
>   locking/rwsem/x86: Add stack frame dependency for __up_write()
>   locking/rwsem/x86: Add stack frame dependency for __downgrade_write()
> 
>  arch/x86/include/asm/rwsem.h | 18 ++++++++++++------
>  1 file changed, 12 insertions(+), 6 deletions(-)

For the series:

Reviewed-by: Josh Poimboeuf <jpoimboe@redhat.com>

-- 
Josh

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] locking/rwsem/x86: Add stack frame dependency for some inline asm Miguel Bernal Marin <miguel.bernal.marin@linux.intel.com> - 2017-09-06 07:30 +0200
  [PATCH v2 0/3] locking/rwsem/x86: Add stack frame dependency for some inline asm Miguel Bernal Marin <miguel.bernal.marin@linux.intel.com> - 2017-09-07 00:50 +0200
    [PATCH v2 1/3] locking/rwsem/x86: Add stack frame dependency for __up_read() Miguel Bernal Marin <miguel.bernal.marin@linux.intel.com> - 2017-09-07 00:50 +0200
      Re: [PATCH v2 1/3] locking/rwsem/x86: Add stack frame dependency for  __up_read() Ingo Molnar <mingo@kernel.org> - 2017-09-07 09:20 +0200
    [PATCH v2 3/3] locking/rwsem/x86: Add stack frame dependency for __downgrade_write() Miguel Bernal Marin <miguel.bernal.marin@linux.intel.com> - 2017-09-07 00:50 +0200
    [PATCH v2 2/3] locking/rwsem/x86: Add stack frame dependency for __up_write() Miguel Bernal Marin <miguel.bernal.marin@linux.intel.com> - 2017-09-07 00:50 +0200
    Re: [PATCH v2 0/3] locking/rwsem/x86: Add stack frame dependency for  some inline asm Josh Poimboeuf <jpoimboe@redhat.com> - 2017-09-07 01:10 +0200

csiph-web