Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1727802

[PATCH v2 0/3] locking/rwsem/x86: Add stack frame dependency for some inline asm

From Miguel Bernal Marin <miguel.bernal.marin@linux.intel.com>
Newsgroups linux.kernel
Subject [PATCH v2 0/3] locking/rwsem/x86: Add stack frame dependency for some inline asm
Date 2017-09-07 00:50 +0200
Message-ID <umRiV-85i-1@gated-at.bofh.it> (permalink)
References <umB4t-5b7-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Some warning were showed by objtool using gcc 7.2.0

kernel/locking/rwsem.o: warning: objtool: up_read()+0x11: call without frame pointer save/setup
kernel/locking/rwsem.o: warning: objtool: up_write()+0x17: call without frame pointer save/setup
kernel/locking/rwsem.o: warning: objtool: downgrade_write()+0x22: call without frame pointer save/setup

which means gcc placed an inline asm function and its call instruction before
the frame pointer setup.
 
This series forces a stack frame to be created before the call instruction
by listing the stack pointer as an output operand in the inline asm statement.

Changes in v2:
  - Update first parameter from _ASM_ADD to '%3' at __downgrade_write()

Miguel Bernal Marin (3):
  locking/rwsem/x86: Add stack frame dependency for __up_read()
  locking/rwsem/x86: Add stack frame dependency for __up_write()
  locking/rwsem/x86: Add stack frame dependency for __downgrade_write()

 arch/x86/include/asm/rwsem.h | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

-- 
2.14.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/3] locking/rwsem/x86: Add stack frame dependency for some inline asm Miguel Bernal Marin <miguel.bernal.marin@linux.intel.com> - 2017-09-06 07:30 +0200
  [PATCH v2 0/3] locking/rwsem/x86: Add stack frame dependency for some inline asm Miguel Bernal Marin <miguel.bernal.marin@linux.intel.com> - 2017-09-07 00:50 +0200
    [PATCH v2 1/3] locking/rwsem/x86: Add stack frame dependency for __up_read() Miguel Bernal Marin <miguel.bernal.marin@linux.intel.com> - 2017-09-07 00:50 +0200
      Re: [PATCH v2 1/3] locking/rwsem/x86: Add stack frame dependency for  __up_read() Ingo Molnar <mingo@kernel.org> - 2017-09-07 09:20 +0200
    [PATCH v2 3/3] locking/rwsem/x86: Add stack frame dependency for __downgrade_write() Miguel Bernal Marin <miguel.bernal.marin@linux.intel.com> - 2017-09-07 00:50 +0200
    [PATCH v2 2/3] locking/rwsem/x86: Add stack frame dependency for __up_write() Miguel Bernal Marin <miguel.bernal.marin@linux.intel.com> - 2017-09-07 00:50 +0200
    Re: [PATCH v2 0/3] locking/rwsem/x86: Add stack frame dependency for  some inline asm Josh Poimboeuf <jpoimboe@redhat.com> - 2017-09-07 01:10 +0200

csiph-web