Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1727762
| Path | csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Dan Carpenter <dan.carpenter@oracle.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3] Staging: ccree: ssi_cipher.c: Remove unused variable. |
| Date | Wed, 06 Sep 2017 23:40:03 +0200 |
| Message-ID | <umQdd-7qi-25@gated-at.bofh.it> (permalink) |
| References | <umPTQ-7jw-19@gated-at.bofh.it> |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=utf-8 |
| Content-Disposition | inline |
| Content-Transfer-Encoding | 8bit |
| User-Agent | NeoMutt/20170113 (1.7.2) |
| X-Source-IP | aserv0021.oracle.com [141.146.126.233] |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 20 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, outreachy-kernel@googlegroups.com, driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org |
| X-Original-Date | Thu, 7 Sep 2017 00:32:43 +0300 |
| X-Original-Message-ID | <20170906213243.gyttos3s64ckoswp@mwanda> |
| X-Original-References | <1504732426-9765-1-git-send-email-srishtishar@gmail.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1727762 |
Show key headers only | View raw
Always compile your patches.
CC [M] drivers/staging/ccree/ssi_cipher.o
drivers/staging/ccree/ssi_cipher.c: In function ‘ssi_blkcipher_complete’:
drivers/staging/ccree/ssi_cipher.c:700:6: warning: unused variable ‘inflight_counter’ [-Wunused-variable]
u32 inflight_counter;
^~~~~~~~~~~~~~~~
You need to delete the declaration as well.
Don't be in a rush to resend patches. I normally write them then let
them sit in my outbox overnight and send them in the morning. The extra
delay helps me to calm down a bit and focus better. Even though I've
sent thousands of patches, it sometimes still stresses me out. It's
like you're disagreeing with the original author and the reviewers are
disagreeing with you and everyone's trying to be nice about it but
patches are fundamentally points of disagreement and that's stress.
regards,
dan carpenter
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3] Staging: ccree: ssi_cipher.c: Remove unused variable. Srishti Sharma <srishtishar@gmail.com> - 2017-09-06 23:20 +0200
Re: [Outreachy kernel] [PATCH v3] Staging: ccree: ssi_cipher.c: Remove unused variable. Julia Lawall <julia.lawall@lip6.fr> - 2017-09-06 23:20 +0200
Re: [Outreachy kernel] [PATCH v3] Staging: ccree: ssi_cipher.c: Remove unused variable. Srishti Sharma <srishtishar@gmail.com> - 2017-09-06 23:30 +0200
Re: [Outreachy kernel] [PATCH v3] Staging: ccree: ssi_cipher.c: Remove unused variable. Srishti Sharma <srishtishar@gmail.com> - 2017-09-06 23:30 +0200
Re: [Outreachy kernel] [PATCH v3] Staging: ccree: ssi_cipher.c: Remove unused variable. Julia Lawall <julia.lawall@lip6.fr> - 2017-09-06 23:30 +0200
Re: [PATCH v3] Staging: ccree: ssi_cipher.c: Remove unused variable. Dan Carpenter <dan.carpenter@oracle.com> - 2017-09-06 23:40 +0200
Re: [PATCH v3] Staging: ccree: ssi_cipher.c: Remove unused variable. Srishti Sharma <srishtishar@gmail.com> - 2017-09-06 23:50 +0200
Re: [PATCH v3] Staging: ccree: ssi_cipher.c: Remove unused variable. Joe Perches <joe@perches.com> - 2017-09-07 08:20 +0200
csiph-web