Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1727780

Re: [PATCH v3] Staging: ccree: ssi_cipher.c: Remove unused variable.

Show all headers | View raw

On Thu, Sep 7, 2017 at 3:02 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> Always compile your patches.
>
>   CC [M]  drivers/staging/ccree/ssi_cipher.o
> drivers/staging/ccree/ssi_cipher.c: In function ‘ssi_blkcipher_complete’:
> drivers/staging/ccree/ssi_cipher.c:700:6: warning: unused variable ‘inflight_counter’ [-Wunused-variable]
>   u32 inflight_counter;
>       ^~~~~~~~~~~~~~~~
>
> You need to delete the declaration as well.
>
> Don't be in a rush to resend patches.  I normally write them then let
> them sit in my outbox overnight and send them in the morning.  The extra
> delay helps me to calm down a bit and focus better.  Even though I've
> sent thousands of patches, it sometimes still stresses me out.  It's
> like you're disagreeing with the original author and the reviewers are
> disagreeing with you and everyone's trying to be nice about it but
> patches are fundamentally points of disagreement and that's stress.
>
> regards,
> dan carpenter
>
 Thanks , I'll be more careful !

 Regards,
 Srishti

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3] Staging: ccree: ssi_cipher.c: Remove unused variable. Srishti Sharma <srishtishar@gmail.com> - 2017-09-06 23:20 +0200
  Re: [Outreachy kernel] [PATCH v3] Staging: ccree: ssi_cipher.c:  Remove unused variable. Julia Lawall <julia.lawall@lip6.fr> - 2017-09-06 23:20 +0200
    Re: [Outreachy kernel] [PATCH v3] Staging: ccree: ssi_cipher.c:  Remove unused variable. Srishti Sharma <srishtishar@gmail.com> - 2017-09-06 23:30 +0200
      Re: [Outreachy kernel] [PATCH v3] Staging: ccree: ssi_cipher.c:  Remove unused variable. Srishti Sharma <srishtishar@gmail.com> - 2017-09-06 23:30 +0200
      Re: [Outreachy kernel] [PATCH v3] Staging: ccree: ssi_cipher.c:  Remove unused variable. Julia Lawall <julia.lawall@lip6.fr> - 2017-09-06 23:30 +0200
  Re: [PATCH v3] Staging: ccree: ssi_cipher.c: Remove unused variable. Dan Carpenter <dan.carpenter@oracle.com> - 2017-09-06 23:40 +0200
    Re: [PATCH v3] Staging: ccree: ssi_cipher.c: Remove unused variable. Srishti Sharma <srishtishar@gmail.com> - 2017-09-06 23:50 +0200
    Re: [PATCH v3] Staging: ccree: ssi_cipher.c: Remove unused variable. Joe Perches <joe@perches.com> - 2017-09-07 08:20 +0200

csiph-web