[PATCH 0/3] phy: rockchip-typec: Set "flip" at the right time; some cleanups

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Douglas Anderson <dianders@chromium.org>
Newsgroups	linux.kernel
Subject	[PATCH 0/3] phy: rockchip-typec: Set "flip" at the right time; some cleanups
Date	Wed, 06 Sep 2017 23:00:01 +0200
Message-ID	<umPAt-6Vc-1@gated-at.bofh.it> (permalink)
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id; bh=ULksJmJ7yoE/S5uDlsKvpJf2OHxuE7iZ6/wsXZahNsY=; b=Q9MB5q+WkdN1uWJLiS+e6VFnASraoMmo/NpxXgdY/uNd60x34whZ7oYffmgwKpN1hZ I62i6uxqjxqoBbI/D82Y0zJbV4HSlTY3j1dbnyL4WkWiwc7LBx+Ys1opF63LV07gBgX0 0qSd0ExVcMjkPfFBrv2j1OxfqU4+kEo/P6SLk=
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ULksJmJ7yoE/S5uDlsKvpJf2OHxuE7iZ6/wsXZahNsY=; b=cVgeGr1XVUE6Wn50V72QGMjksnQ+DmQsRxZJtLOXramnsyP8MPqz02hKZB96pct4MT 02h8AoPGgRUuNBLpkA3aecl6Wubfw8VTmJBN2ZkVqIp21bbDjHxW8axMqg777fcWG4xL Jk5dqTghBb75VzKnDv3t62al7m2t0LnNet9xkp04opLAwbOy4xOBWCboKrCZ1rFgn5Gy sD4Y7QpRbGXMGU+Jr1u58n6wXZJkHB/Ackbv0ugOcoSYA0RqnTj45p13MuIynA1cujkG kBhzjBTdH6LYVOP0kVLlwJ/ZShG+iUsPhm1YmvwN/tAIN8GvsB6X4VLr2GZKMgtbH9fu 9TOw==
X-Gm-Message-State	AHPjjUhEIt/a6jICY2Q5ThHBrxy4PydJZvRI19p9+0VN6b8zVJAhFWAQ eF+JSmg0xAKAu2yt
X-Google-SMTP-Source	ADKCNb7ydDOb9xHfE18OL+4+NtqMKXHlPIo/M4CXhltBrYO1IMRQzw8wqQpB3RI+Zhfln2fd7Wbxkg==
X-Received	by 10.84.130.78 with SMTP id 72mr435050plc.245.1504731161545; Wed, 06 Sep 2017 13:52:41 -0700 (PDT)
X-Mailer	git-send-email 2.14.1.581.gf28d330327-goog
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	27
Organization	linux.* mail to news gateway
X-Original-Cc	shawnn@chromium.org, dnschneid@chromium.org, Douglas Anderson <dianders@chromium.org>, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
X-Original-Date	Wed, 6 Sep 2017 13:51:58 -0700
X-Original-Message-ID	<20170906205201.16207-1-dianders@chromium.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1727727

Show key headers only | View raw

When connecting to certain DP monitors it was observed that only one
of the two orientations of the type C to DP cable would work.
Debugging showed that the problem was that we needed to set the type C
"flip" state earlier.  Once we did this, problems went away.

While trying to dig into this problem and some others, I found that
the proper documentation for the Type C PHY was available to me.  This
allowed me to cleanup the magic numbers in the funtion that I was
touching and also fix a few minor issues that (luckily) haven't caused
any problems yet.

For this series I've added Chris Zhong's Reviewed-by tags since he
gave a +1 to nearly identical patches on the Chrome OS gerrit and I
didn't think he'd mind me carrying his tag.  If folks would rather I
didn't do that, please yell.


Douglas Anderson (3):
  phy: rockchip-typec: Set the AUX channel flip state earlier
  phy: rockchip-typec: Avoid magic numbers + add delays in aux calib
  phy: rockchip-typec: Do the calibration more correctly

 drivers/phy/rockchip/phy-rockchip-typec.c | 247 ++++++++++++++++++++++++------
 1 file changed, 202 insertions(+), 45 deletions(-)

-- 
2.14.1.581.gf28d330327-goog

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] phy: rockchip-typec: Set "flip" at the right time; some cleanups Douglas Anderson <dianders@chromium.org> - 2017-09-06 23:00 +0200
  [PATCH 2/3] phy: rockchip-typec: Avoid magic numbers + add delays in aux calib Douglas Anderson <dianders@chromium.org> - 2017-09-06 23:00 +0200
  [PATCH 3/3] phy: rockchip-typec: Do the calibration more correctly Douglas Anderson <dianders@chromium.org> - 2017-09-06 23:00 +0200
    Re: [PATCH 3/3] phy: rockchip-typec: Do the calibration more correctly Doug Anderson <dianders@chromium.org> - 2017-09-06 23:30 +0200
  [PATCH 1/3] phy: rockchip-typec: Set the AUX channel flip state earlier Douglas Anderson <dianders@chromium.org> - 2017-09-06 23:00 +0200

csiph-web