Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1727727

[PATCH 0/3] phy: rockchip-typec: Set "flip" at the right time; some cleanups

Show all headers | View raw

When connecting to certain DP monitors it was observed that only one
of the two orientations of the type C to DP cable would work.
Debugging showed that the problem was that we needed to set the type C
"flip" state earlier.  Once we did this, problems went away.

While trying to dig into this problem and some others, I found that
the proper documentation for the Type C PHY was available to me.  This
allowed me to cleanup the magic numbers in the funtion that I was
touching and also fix a few minor issues that (luckily) haven't caused
any problems yet.

For this series I've added Chris Zhong's Reviewed-by tags since he
gave a +1 to nearly identical patches on the Chrome OS gerrit and I
didn't think he'd mind me carrying his tag.  If folks would rather I
didn't do that, please yell.


Douglas Anderson (3):
  phy: rockchip-typec: Set the AUX channel flip state earlier
  phy: rockchip-typec: Avoid magic numbers + add delays in aux calib
  phy: rockchip-typec: Do the calibration more correctly

 drivers/phy/rockchip/phy-rockchip-typec.c | 247 ++++++++++++++++++++++++------
 1 file changed, 202 insertions(+), 45 deletions(-)

-- 
2.14.1.581.gf28d330327-goog

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] phy: rockchip-typec: Set "flip" at the right time; some cleanups Douglas Anderson <dianders@chromium.org> - 2017-09-06 23:00 +0200
  [PATCH 2/3] phy: rockchip-typec: Avoid magic numbers + add delays in aux calib Douglas Anderson <dianders@chromium.org> - 2017-09-06 23:00 +0200
  [PATCH 3/3] phy: rockchip-typec: Do the calibration more correctly Douglas Anderson <dianders@chromium.org> - 2017-09-06 23:00 +0200
    Re: [PATCH 3/3] phy: rockchip-typec: Do the calibration more correctly Doug Anderson <dianders@chromium.org> - 2017-09-06 23:30 +0200
  [PATCH 1/3] phy: rockchip-typec: Set the AUX channel flip state earlier Douglas Anderson <dianders@chromium.org> - 2017-09-06 23:00 +0200

csiph-web