Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1725655

[PATCH 4/10] drm/nouveau/bios/init: Use ARRAY_SIZE macro

Show all headers | View raw

Use ARRAY_SIZE macro, rather than explicitly coding some variant of it
yourself.
Found with: find -type f -name "*.c" -o -name "*.h" | xargs perl -p -i -e
's/\bsizeof\s*\(\s*(\w+)\s*\)\s*\ /\s*sizeof\s*\(\s*\1\s*\[\s*0\s*\]\s*\)
/ARRAY_SIZE(\1)/g' and manual check/verification.

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---

diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c
index b58ee99f7bfc..440efa333d6c 100644
--- a/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c
+++ b/drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c
@@ -21,6 +21,7 @@
  *
  * Authors: Ben Skeggs
  */
+#include <linux/kernel.h>
 #include <subdev/bios.h>
 #include <subdev/bios/bit.h>
 #include <subdev/bios/bmp.h>
@@ -2271,7 +2272,7 @@ static struct nvbios_init_opcode {
 	[0xaa] = { init_reserved },
 };
 
-#define init_opcode_nr (sizeof(init_opcode) / sizeof(init_opcode[0]))
+#define init_opcode_nr (ARRAY_SIZE(init_opcode))
 
 int
 nvbios_exec(struct nvbios_init *init)

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/10] Use ARRAY_SIZE macro - v4.13-rc7 Thomas Meyer <thomas@m3y3r.de> - 2017-09-03 14:40 +0200
  [PATCH 8/10] ath9k: Use ARRAY_SIZE macro Thomas Meyer <thomas@m3y3r.de> - 2017-09-03 14:40 +0200
  [PATCH 4/10] drm/nouveau/bios/init: Use ARRAY_SIZE macro Thomas Meyer <thomas@m3y3r.de> - 2017-09-03 14:40 +0200
  [PATCH 10/10] staging/atomisp: Use ARRAY_SIZE macro Thomas Meyer <thomas@m3y3r.de> - 2017-09-03 14:40 +0200
  [PATCH 9/10] [SCSI] bfa: Use ARRAY_SIZE macro Thomas Meyer <thomas@m3y3r.de> - 2017-09-03 14:40 +0200
  [PATCH 6/10] ixgbe: Use ARRAY_SIZE macro Thomas Meyer <thomas@m3y3r.de> - 2017-09-03 14:40 +0200
    Re: [PATCH 6/10] ixgbe: Use ARRAY_SIZE macro David Miller <davem@davemloft.net> - 2017-09-05 21:00 +0200
      Re: [PATCH 6/10] ixgbe: Use ARRAY_SIZE macro Thomas Meyer <thomas@m3y3r.de> - 2017-09-05 21:50 +0200
        Re: [PATCH 6/10] ixgbe: Use ARRAY_SIZE macro Joe Perches <joe@perches.com> - 2017-09-05 22:10 +0200
          Re: [PATCH 6/10] ixgbe: Use ARRAY_SIZE macro David Miller <davem@davemloft.net> - 2017-09-05 23:30 +0200
            Re: [PATCH 6/10] ixgbe: Use ARRAY_SIZE macro Thomas Meyer <thomas@m3y3r.de> - 2017-09-06 11:10 +0200
              Re: [PATCH 6/10] ixgbe: Use ARRAY_SIZE macro Joe Perches <joe@perches.com> - 2017-09-06 17:20 +0200
  [PATCH 2/10] drm/amdgpu: Use ARRAY_SIZE macro Thomas Meyer <thomas@m3y3r.de> - 2017-09-03 14:40 +0200
  [PATCH 5/10] [media] lgdt3306a: Use ARRAY_SIZE macro Thomas Meyer <thomas@m3y3r.de> - 2017-09-03 14:40 +0200
  Re: [PATCH 0/10] Use ARRAY_SIZE macro - v4.13-rc7 Joe Perches <joe@perches.com> - 2017-09-03 17:40 +0200
    Re: [PATCH 0/10] Use ARRAY_SIZE macro - v4.13-rc7 Thomas Meyer <thomas@m3y3r.de> - 2017-09-03 22:00 +0200
      Re: [PATCH 0/10] Use ARRAY_SIZE macro - v4.13-rc7 Joe Perches <joe@perches.com> - 2017-09-03 22:30 +0200

csiph-web