Re: [RFC v2 1/6] platform/x86: intel_pmc_ipc: Use devm_* calls in driver probe function

From	Andy Shevchenko <andy.shevchenko@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [RFC v2 1/6] platform/x86: intel_pmc_ipc: Use devm_* calls in driver probe function
Date	2017-09-03 14:40 +0200
Message-ID	<ulClX-8pn-11@gated-at.bofh.it> (permalink)
References	<ulrTA-1RK-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Sep 3, 2017 at 4:24 AM,
<sathyanarayanan.kuppuswamy@linux.intel.com> wrote:
> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>
> This patch cleans up unnecessary free/alloc calls in ipc_plat_probe(),
> ipc_pci_probe() and ipc_plat_get_res() functions by using devm_*
> calls.
>
> This patch also adds proper error handling for failure cases in
> ipc_pci_probe() function.

>         ret = pci_enable_device(pdev);
>         if (ret)
> -               return ret;
> +               goto release_device;

Instead you should use PCI managed function(s).

-- 
With Best Regards,
Andy Shevchenko

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC v2 1/6] platform/x86: intel_pmc_ipc: Use devm_* calls in driver probe function sathyanarayanan.kuppuswamy@linux.intel.com - 2017-09-03 03:30 +0200
  Re: [RFC v2 1/6] platform/x86: intel_pmc_ipc: Use devm_* calls in  driver probe function Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-09-03 14:40 +0200

csiph-web