Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1724140

[PATCH v3 4/5] sched/fair: Fix use of find_idlest_group when no groups are allowed

Show all headers | View raw

When p is allowed on none of the CPUs in the sched_domain, we
currently return NULL from find_idlest_group, and pointlessly
continue the search on lower sched_domain levels (where p is also not
allowed) before returning prev_cpu regardless (as we have not updated
new_cpu).

Add an explicit check for this case, and a comment to
find_idlest_group. Now when find_idlest_group returns NULL, it always
means that the local group is allowed and idlest.

Signed-off-by: Brendan Jackman <brendan.jackman@arm.com>
Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Josef Bacik <josef@toxicpanda.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Morten Rasmussen <morten.rasmussen@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
---
 kernel/sched/fair.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 0ce75bb..2608091 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -5380,6 +5380,8 @@ static unsigned long capacity_spare_wake(int cpu, struct task_struct *p)
 /*
  * find_idlest_group finds and returns the least busy CPU group within the
  * domain.
+ *
+ * Assumes p is allowed on at least one CPU in sd.
  */
 static struct sched_group *
 find_idlest_group(struct sched_domain *sd, struct task_struct *p,
@@ -5567,6 +5569,9 @@ static inline int find_idlest_cpu(struct sched_domain *sd, struct task_struct *p
 {
 	int new_cpu = prev_cpu;
 
+	if (!cpumask_intersects(sched_domain_span(sd), &p->cpus_allowed))
+		return prev_cpu;
+
 	while (sd) {
 		struct sched_group *group;
 		struct sched_domain *tmp;
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/5] sched/fair: Tweaks for select_task_rq_fair slowpath Brendan Jackman <brendan.jackman@arm.com> - 2017-08-31 14:00 +0200
  [PATCH v3 3/5] sched/fair: Fix find_idlest_group when local group is not allowed Brendan Jackman <brendan.jackman@arm.com> - 2017-08-31 14:00 +0200
    Re: [PATCH v3 3/5] sched/fair: Fix find_idlest_group when local  group is not allowed Josef Bacik <josef@toxicpanda.com> - 2017-08-31 16:00 +0200
  [PATCH v3 2/5] sched/fair: Remove unnecessary comparison with -1 Brendan Jackman <brendan.jackman@arm.com> - 2017-08-31 14:00 +0200
  [PATCH v3 4/5] sched/fair: Fix use of find_idlest_group when no groups are allowed Brendan Jackman <brendan.jackman@arm.com> - 2017-08-31 14:00 +0200
    Re: [PATCH v3 4/5] sched/fair: Fix use of find_idlest_group when no  groups are allowed Josef Bacik <josef@toxicpanda.com> - 2017-08-31 16:00 +0200
  [PATCH v3 5/5] sched/fair: Fix use of find_idlest_group when local group is idlest Brendan Jackman <brendan.jackman@arm.com> - 2017-08-31 14:00 +0200
    Re: [PATCH v3 5/5] sched/fair: Fix use of find_idlest_group when  local group is idlest Josef Bacik <josef@toxicpanda.com> - 2017-08-31 16:00 +0200
    Re: [PATCH v3 5/5] sched/fair: Fix use of find_idlest_group when  local group is idlest Vincent Guittot <vincent.guittot@linaro.org> - 2017-08-31 18:20 +0200
  [PATCH v3 1/5] sched/fair: Move select_task_rq_fair slow-path into its own function Brendan Jackman <brendan.jackman@arm.com> - 2017-08-31 14:00 +0200

csiph-web