Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1724141

[PATCH v3 5/5] sched/fair: Fix use of find_idlest_group when local group is idlest

Show all headers | View raw

find_idlest_group returns NULL when the local group is idlest. The
caller then continues the find_idlest_group search at a lower level
of the current CPU's sched_domain hierarchy. find_idlest_group_cpu is
not consulted and, crucially, @new_cpu is not updated. This means the
search is pointless and we return @prev_cpu from select_task_rq_fair.

This is fixed by initialising @new_cpu to @cpu instead of
@prev_cpu.

Signed-off-by: Brendan Jackman <brendan.jackman@arm.com>
Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Josef Bacik <josef@toxicpanda.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Morten Rasmussen <morten.rasmussen@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
---
 kernel/sched/fair.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 2608091..f93cb97 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -5567,7 +5567,7 @@ find_idlest_group_cpu(struct sched_group *group, struct task_struct *p, int this
 static inline int find_idlest_cpu(struct sched_domain *sd, struct task_struct *p,
 				  int cpu, int prev_cpu, int sd_flag)
 {
-	int new_cpu = prev_cpu;
+	int new_cpu = cpu;
 
 	if (!cpumask_intersects(sched_domain_span(sd), &p->cpus_allowed))
 		return prev_cpu;
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/5] sched/fair: Tweaks for select_task_rq_fair slowpath Brendan Jackman <brendan.jackman@arm.com> - 2017-08-31 14:00 +0200
  [PATCH v3 3/5] sched/fair: Fix find_idlest_group when local group is not allowed Brendan Jackman <brendan.jackman@arm.com> - 2017-08-31 14:00 +0200
    Re: [PATCH v3 3/5] sched/fair: Fix find_idlest_group when local  group is not allowed Josef Bacik <josef@toxicpanda.com> - 2017-08-31 16:00 +0200
  [PATCH v3 2/5] sched/fair: Remove unnecessary comparison with -1 Brendan Jackman <brendan.jackman@arm.com> - 2017-08-31 14:00 +0200
  [PATCH v3 4/5] sched/fair: Fix use of find_idlest_group when no groups are allowed Brendan Jackman <brendan.jackman@arm.com> - 2017-08-31 14:00 +0200
    Re: [PATCH v3 4/5] sched/fair: Fix use of find_idlest_group when no  groups are allowed Josef Bacik <josef@toxicpanda.com> - 2017-08-31 16:00 +0200
  [PATCH v3 5/5] sched/fair: Fix use of find_idlest_group when local group is idlest Brendan Jackman <brendan.jackman@arm.com> - 2017-08-31 14:00 +0200
    Re: [PATCH v3 5/5] sched/fair: Fix use of find_idlest_group when  local group is idlest Josef Bacik <josef@toxicpanda.com> - 2017-08-31 16:00 +0200
    Re: [PATCH v3 5/5] sched/fair: Fix use of find_idlest_group when  local group is idlest Vincent Guittot <vincent.guittot@linaro.org> - 2017-08-31 18:20 +0200
  [PATCH v3 1/5] sched/fair: Move select_task_rq_fair slow-path into its own function Brendan Jackman <brendan.jackman@arm.com> - 2017-08-31 14:00 +0200

csiph-web