Re: [PATCH v6 1/2] platform: Add driver for RAVE Supervisory Processor

From	Pavel Machek <pavel@ucw.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 1/2] platform: Add driver for RAVE Supervisory Processor
Date	2017-08-31 10:20 +0200
Message-ID	<uksRH-3bX-9@gated-at.bofh.it> (permalink)
References	(1 earlier) <ujveW-7TT-23@gated-at.bofh.it> <uk8T0-7g3-11@gated-at.bofh.it> <ukgxb-3Pz-9@gated-at.bofh.it> <ukhWi-4BB-7@gated-at.bofh.it> <uksRH-3bX-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu 2017-08-31 11:10:35, Nikita Yushchenko wrote:
> 
> 
> 30.08.2017 23:38, Pavel Machek wrote:
> > Hi!
> > 
> >>>> +                 * 9  -> Illegal Trap
> >>>> +                 * 10 -> Unknown
> >>>> +                 * 11 -> Crew Panel Requested
> >>>
> >>> Anyway... If you move management chip to .. I don't know, i2c, the
> >>> path would change. Also it would be different path on N900. Userland
> >>> should not have to deal with this.
> >>>
> >>> And... this should really be string, as the list will need to grow on
> >>> different hardware.
> >>
> >> I think we have a misunderstanding, with this part of the patch set I
> >> am not trying to propose a generic ABI that would be useful for any
> >> other driver but this one. Hence the lack of concern for different
> > 
> > Yes, but sorry, that's no-go.  Kernel should hide differences between
> > different machiens, and it should be rather easy in this case.
> 
> There is an interest to have reset reason exported on other ZII hardware
> as well.
> 
> I think that trying to make this generic is purely synthetic. This
> information is board-specific per it's nature, it comes from what board
> is designed for, different boards have quite different sets of possible
> reset reasons. What is needed is - pass this board-specific information
> to board-specific user space.
> 
> What's proper API for that, if not a sysfs attribute?

Please go through the thread.

Sysfs attribute is okay, but:

1) it should probably be a string

2) it should certainly be superset of all the reasons

3) it should be in generic place, say /sys/power/reset_reason

4) it should be documented what each state means
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Thread

[PATCH v6 0/2] ZII RAVE platform driver Andrey Smirnov <andrew.smirnov@gmail.com> - 2017-08-28 18:40 +0200
  Re: [PATCH v6 1/2] platform: Add driver for RAVE Supervisory  Processor Pavel Machek <pavel@ucw.cz> - 2017-08-30 13:00 +0200
    Re: [PATCH v6 1/2] platform: Add driver for RAVE Supervisory Processor Andrey Smirnov <andrew.smirnov@gmail.com> - 2017-08-30 21:10 +0200
      Re: [PATCH v6 1/2] platform: Add driver for RAVE Supervisory  Processor Pavel Machek <pavel@ucw.cz> - 2017-08-30 22:40 +0200
        Re: [PATCH v6 1/2] platform: Add driver for RAVE Supervisory  Processor Pavel Machek <pavel@ucw.cz> - 2017-08-31 10:20 +0200
          Re: [PATCH v6 1/2] platform: Add driver for RAVE Supervisory  Processor Nikita Yushchenko <nikita.yoush@cogentembedded.com> - 2017-08-31 11:10 +0200
            Re: [PATCH v6 1/2] platform: Add driver for RAVE Supervisory  Processor Pavel Machek <pavel@ucw.cz> - 2017-08-31 11:20 +0200
        Re: [PATCH v6 1/2] platform: Add driver for RAVE Supervisory  Processor Nikita Yushchenko <nikita.yoush@cogentembedded.com> - 2017-08-31 10:20 +0200
  Re: [PATCH v6 1/2] platform: Add driver for RAVE Supervisory  Processor Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-31 18:50 +0200

csiph-web