Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1723803

Re: [PATCH v3 1/6] android: binder: Refactor prev and next buffer into a helper function

Show all headers | View raw

On Wed, Aug 30, 2017 at 12:46:38PM -0700, Sherry Yang wrote:
> On Tue, Aug 29, 2017 at 11:07 PM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > On Tue, Aug 29, 2017 at 05:46:57PM -0700, Sherry Yang wrote:
> >> Use helper functions buffer_next and buffer_prev instead
> >> of list_entry to get the next and previous buffers.
> >>
> >> Signed-off-by: Sherry Yang <sherryy@android.com>
> >> ---
> >>  drivers/android/binder_alloc.c | 24 +++++++++++++++---------
> >>  1 file changed, 15 insertions(+), 9 deletions(-)
> >
> > What changed from the previous version?
> 
> This specific patch didn't change. The change is only in [patch v3
> 3/6] (crash fix) and in [patch v3 6/6] (new patch that add stats).

I need to know that :)

> > Always put the changes below the --- line.  Like the documentation says
> > to do so.
> 
> Do you mean I should use --annotate to git send-email to specify what
> has changed across versions for each patch? I used --compose and put
> what changed from v2 to v3 in the introductory message [patch 0/6].

I never got a patch 0/6 here, and honestly, almost always ignore them as
patches should be self-obvious :)

> > Also, don't I already have these patches in my tree?  Do you want me to
> > revert the existing ones and use the new ones, or what about a fixup
> > patch for any differences?
> 
> I got a message saying a test failed on [patch 3/5]. I resubmitted the
> entire thread because I wasn't sure if you would drop the failing
> patch set. If the entire failing patch set is dropped, then v3 can be
> used as a replacement.

Do you want me to revert all of these?  I can not "drop" them as my tree
can not rebase.  If it's just a simple fix, I'll gladly take that
instead.

> If you prefer a fixup patch, I can post another patch set (the crash
> fix and the new patch) on top of what you already applied, but it
> might be easier to do what's described in the previous paragraph (drop
> v2 and apply v3).

Ok, exactly what git commit ids should I revert from the tree?  But
really, a fix would be easier at this point :)

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] android: binder: move allocator metadata and add shrinker Sherry Yang <sherryy@android.com> - 2017-08-30 02:50 +0200
  [PATCH v3 2/6] android: binder: Add allocator selftest Sherry Yang <sherryy@android.com> - 2017-08-30 02:50 +0200
  [PATCH v3 1/6] android: binder: Refactor prev and next buffer into a helper function Sherry Yang <sherryy@android.com> - 2017-08-30 02:50 +0200
    Re: [PATCH v3 1/6] android: binder: Refactor prev and next buffer  into a helper function Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-30 08:20 +0200
      Re: [PATCH v3 1/6] android: binder: Refactor prev and next buffer  into a helper function Sherry Yang <sherryy@android.com> - 2017-08-30 21:50 +0200
        Re: [PATCH v3 1/6] android: binder: Refactor prev and next buffer  into a helper function Dan Carpenter <dan.carpenter@oracle.com> - 2017-08-30 22:10 +0200
        Re: [PATCH v3 1/6] android: binder: Refactor prev and next buffer  into a helper function Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-31 06:30 +0200
          [PATCH] android: binder: fixup crash introduced by moving buffer hdr Sherry Yang <sherryy@android.com> - 2017-08-31 19:30 +0200
            Re: [PATCH] android: binder: fixup crash introduced by moving buffer  hdr Greg KH <gregkh@linuxfoundation.org> - 2017-09-01 09:00 +0200
          Re: [PATCH v3 1/6] android: binder: Refactor prev and next buffer  into a helper function Sherry Yang <sherryy@android.com> - 2017-08-31 19:40 +0200
            Re: [PATCH v3 1/6] android: binder: Refactor prev and next buffer  into a helper function Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-31 20:50 +0200
              [PATCH] android: binder: Add page usage in binder stats Sherry Yang <sherryy@android.com> - 2017-08-31 21:00 +0200
  [PATCH v3 6/6] android: binder: Add page usage in binder stats Sherry Yang <sherryy@android.com> - 2017-08-30 02:50 +0200
  [PATCH v3 3/6] android: binder: Move buffer out of area shared with user space Sherry Yang <sherryy@android.com> - 2017-08-30 02:50 +0200
    Re: [PATCH v3 3/6] android: binder: Move buffer out of area shared  with user space Dan Carpenter <dan.carpenter@oracle.com> - 2017-08-30 11:40 +0200
      Re: [PATCH v3 3/6] android: binder: Move buffer out of area shared  with user space Arve Hjønnevåg <arve@android.com> - 2017-08-30 22:10 +0200
        Re: [PATCH v3 3/6] android: binder: Move buffer out of area shared  with user space Dan Carpenter <dan.carpenter@oracle.com> - 2017-08-30 22:30 +0200
          Re: [PATCH v3 3/6] android: binder: Move buffer out of area shared  with user space Todd Kjos <tkjos@google.com> - 2017-08-30 23:10 +0200
  [PATCH v3 4/6] android: binder: Add global lru shrinker to binder Sherry Yang <sherryy@android.com> - 2017-08-30 02:50 +0200
  [PATCH v3 5/6] android: binder: Add shrinker tracepoints Sherry Yang <sherryy@android.com> - 2017-08-30 02:50 +0200

csiph-web