Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1724815

Re: [PATCH] android: binder: fixup crash introduced by moving buffer hdr

Show all headers | View raw

On Thu, Aug 31, 2017 at 10:26:06AM -0700, Sherry Yang wrote:
> Fix crash introduced by 74310e06be4d74dcf67cd108366710dee5c576d5
> (android: binder: Move buffer out of area shared with user space)
> when close is called after open without mmap in between.
> 
> Signed-off-by: Sherry Yang <sherryy@android.com>
> ---
>  drivers/android/binder_alloc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

In the future, please include a "Reported-by:" tag that shows who
reported the issue, and a Fixes: tag with the info for what commit this
fixes.

And no need to give the full sha1, you can shorten it, this is the
standard for kernel commit:
	74310e06be4d ("android: binder: Move buffer out of area shared with user space")

I'll edit this patch up with that info, but in the future, please do
this yourself.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] android: binder: move allocator metadata and add shrinker Sherry Yang <sherryy@android.com> - 2017-08-30 02:50 +0200
  [PATCH v3 2/6] android: binder: Add allocator selftest Sherry Yang <sherryy@android.com> - 2017-08-30 02:50 +0200
  [PATCH v3 1/6] android: binder: Refactor prev and next buffer into a helper function Sherry Yang <sherryy@android.com> - 2017-08-30 02:50 +0200
    Re: [PATCH v3 1/6] android: binder: Refactor prev and next buffer  into a helper function Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-30 08:20 +0200
      Re: [PATCH v3 1/6] android: binder: Refactor prev and next buffer  into a helper function Sherry Yang <sherryy@android.com> - 2017-08-30 21:50 +0200
        Re: [PATCH v3 1/6] android: binder: Refactor prev and next buffer  into a helper function Dan Carpenter <dan.carpenter@oracle.com> - 2017-08-30 22:10 +0200
        Re: [PATCH v3 1/6] android: binder: Refactor prev and next buffer  into a helper function Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-31 06:30 +0200
          [PATCH] android: binder: fixup crash introduced by moving buffer hdr Sherry Yang <sherryy@android.com> - 2017-08-31 19:30 +0200
            Re: [PATCH] android: binder: fixup crash introduced by moving buffer  hdr Greg KH <gregkh@linuxfoundation.org> - 2017-09-01 09:00 +0200
          Re: [PATCH v3 1/6] android: binder: Refactor prev and next buffer  into a helper function Sherry Yang <sherryy@android.com> - 2017-08-31 19:40 +0200
            Re: [PATCH v3 1/6] android: binder: Refactor prev and next buffer  into a helper function Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-08-31 20:50 +0200
              [PATCH] android: binder: Add page usage in binder stats Sherry Yang <sherryy@android.com> - 2017-08-31 21:00 +0200
  [PATCH v3 6/6] android: binder: Add page usage in binder stats Sherry Yang <sherryy@android.com> - 2017-08-30 02:50 +0200
  [PATCH v3 3/6] android: binder: Move buffer out of area shared with user space Sherry Yang <sherryy@android.com> - 2017-08-30 02:50 +0200
    Re: [PATCH v3 3/6] android: binder: Move buffer out of area shared  with user space Dan Carpenter <dan.carpenter@oracle.com> - 2017-08-30 11:40 +0200
      Re: [PATCH v3 3/6] android: binder: Move buffer out of area shared  with user space Arve Hjønnevåg <arve@android.com> - 2017-08-30 22:10 +0200
        Re: [PATCH v3 3/6] android: binder: Move buffer out of area shared  with user space Dan Carpenter <dan.carpenter@oracle.com> - 2017-08-30 22:30 +0200
          Re: [PATCH v3 3/6] android: binder: Move buffer out of area shared  with user space Todd Kjos <tkjos@google.com> - 2017-08-30 23:10 +0200
  [PATCH v3 4/6] android: binder: Add global lru shrinker to binder Sherry Yang <sherryy@android.com> - 2017-08-30 02:50 +0200
  [PATCH v3 5/6] android: binder: Add shrinker tracepoints Sherry Yang <sherryy@android.com> - 2017-08-30 02:50 +0200

csiph-web