Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1723473

Re: [PATCH 08/16] mm/nommu: switch do_mmap_private to kernel_read

From Al Viro <viro@ZenIV.linux.org.uk>
Newsgroups linux.kernel
Subject Re: [PATCH 08/16] mm/nommu: switch do_mmap_private to kernel_read
Date 2017-08-30 17:50 +0200
Message-ID <ukdpE-1Ib-13@gated-at.bofh.it> (permalink)
References <ukcMW-1sy-9@gated-at.bofh.it> <ukcMX-1sy-33@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Aug 30, 2017 at 04:59:59PM +0200, Christoph Hellwig wrote:
> -		fpos = vma->vm_pgoff;
> -		fpos <<= PAGE_SHIFT;

> +		loff_t fpos = vma->vm_pgoff << PAGE_SHIFT;

Umm...  Are you sure it's OK on 32bit hosts?

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

switch in-kernel read/write calls to kernel_read/write Christoph Hellwig <hch@lst.de> - 2017-08-30 17:10 +0200
  [PATCH 08/16] mm/nommu: switch do_mmap_private to kernel_read Christoph Hellwig <hch@lst.de> - 2017-08-30 17:10 +0200
    Re: [PATCH 08/16] mm/nommu: switch do_mmap_private to kernel_read Al Viro <viro@ZenIV.linux.org.uk> - 2017-08-30 17:50 +0200
      Re: [PATCH 08/16] mm/nommu: switch do_mmap_private to kernel_read Christoph Hellwig <hch@lst.de> - 2017-09-01 12:50 +0200
  [PATCH 09/16] net/9p: switch p9_fd_read to kernel_write Christoph Hellwig <hch@lst.de> - 2017-08-30 17:10 +0200
  [PATCH 15/16] fs: unexport vfs_read and vfs_write Christoph Hellwig <hch@lst.de> - 2017-08-30 17:10 +0200
  [PATCH 02/16] autofs4: switch autofs4_write to __kernel_write Christoph Hellwig <hch@lst.de> - 2017-08-30 17:10 +0200
    Re: [PATCH 02/16] autofs4: switch autofs4_write to __kernel_write Al Viro <viro@ZenIV.linux.org.uk> - 2017-08-30 17:40 +0200
      Re: [PATCH 02/16] autofs4: switch autofs4_write to __kernel_write Christoph Hellwig <hch@lst.de> - 2017-09-01 12:30 +0200
  [PATCH 13/16] lustre: switch to kernel_write Christoph Hellwig <hch@lst.de> - 2017-08-30 17:10 +0200
  [PATCH 03/16] fs: move kernel_write to fs/read_write.c Christoph Hellwig <hch@lst.de> - 2017-08-30 17:10 +0200
  [PATCH 04/16] fs: move kernel_read to fs/read_write.c Christoph Hellwig <hch@lst.de> - 2017-08-30 17:10 +0200
  [PATCH 06/16] fs: fix kernel_write prototype Christoph Hellwig <hch@lst.de> - 2017-08-30 17:10 +0200
    Re: [PATCH 06/16] fs: fix kernel_write prototype Al Viro <viro@ZenIV.linux.org.uk> - 2017-08-30 17:40 +0200
      Re: [PATCH 06/16] fs: fix kernel_write prototype Christoph Hellwig <hch@lst.de> - 2017-09-01 12:50 +0200

csiph-web