Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1724959
| From | Christoph Hellwig <hch@lst.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 06/16] fs: fix kernel_write prototype |
| Date | 2017-09-01 12:50 +0200 |
| Message-ID | <ukRGp-2P1-1@gated-at.bofh.it> (permalink) |
| References | <ukcMW-1sy-9@gated-at.bofh.it> <ukcMY-1sy-65@gated-at.bofh.it> <ukdfY-1Et-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Aug 30, 2017 at 04:39:00PM +0100, Al Viro wrote:
> On Wed, Aug 30, 2017 at 04:59:57PM +0200, Christoph Hellwig wrote:
>
> > for (prot = 0; prot < prot_length;) {
> > sector_t len = min_t(sector_t, bufsize, prot_length - prot);
> > - ssize_t ret = kernel_write(prot_fd, buf, len, pos + prot);
> > + ssize_t ret = kernel_write(prot_fd, buf, len, &pos);
> >
> > if (ret != len) {
> > pr_err("vfs_write to prot file failed: %zd\n", ret);
> > return ret < 0 ? ret : -ENODEV;
> > }
> > - prot += ret;
> > }
>
> And that loop will terminate because of...? IOW, the same bug class as in
> the kernel_read() patch.
Also fixed.
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
switch in-kernel read/write calls to kernel_read/write Christoph Hellwig <hch@lst.de> - 2017-08-30 17:10 +0200
[PATCH 08/16] mm/nommu: switch do_mmap_private to kernel_read Christoph Hellwig <hch@lst.de> - 2017-08-30 17:10 +0200
Re: [PATCH 08/16] mm/nommu: switch do_mmap_private to kernel_read Al Viro <viro@ZenIV.linux.org.uk> - 2017-08-30 17:50 +0200
Re: [PATCH 08/16] mm/nommu: switch do_mmap_private to kernel_read Christoph Hellwig <hch@lst.de> - 2017-09-01 12:50 +0200
[PATCH 09/16] net/9p: switch p9_fd_read to kernel_write Christoph Hellwig <hch@lst.de> - 2017-08-30 17:10 +0200
[PATCH 15/16] fs: unexport vfs_read and vfs_write Christoph Hellwig <hch@lst.de> - 2017-08-30 17:10 +0200
[PATCH 02/16] autofs4: switch autofs4_write to __kernel_write Christoph Hellwig <hch@lst.de> - 2017-08-30 17:10 +0200
Re: [PATCH 02/16] autofs4: switch autofs4_write to __kernel_write Al Viro <viro@ZenIV.linux.org.uk> - 2017-08-30 17:40 +0200
Re: [PATCH 02/16] autofs4: switch autofs4_write to __kernel_write Christoph Hellwig <hch@lst.de> - 2017-09-01 12:30 +0200
[PATCH 13/16] lustre: switch to kernel_write Christoph Hellwig <hch@lst.de> - 2017-08-30 17:10 +0200
[PATCH 03/16] fs: move kernel_write to fs/read_write.c Christoph Hellwig <hch@lst.de> - 2017-08-30 17:10 +0200
[PATCH 04/16] fs: move kernel_read to fs/read_write.c Christoph Hellwig <hch@lst.de> - 2017-08-30 17:10 +0200
[PATCH 06/16] fs: fix kernel_write prototype Christoph Hellwig <hch@lst.de> - 2017-08-30 17:10 +0200
Re: [PATCH 06/16] fs: fix kernel_write prototype Al Viro <viro@ZenIV.linux.org.uk> - 2017-08-30 17:40 +0200
Re: [PATCH 06/16] fs: fix kernel_write prototype Christoph Hellwig <hch@lst.de> - 2017-09-01 12:50 +0200
csiph-web