Re: [RESEND PATCH v5 00/16] eeprom: at24: Add OF device ID table

From	Javier Martinez Canillas <javier@dowhile0.org>
Newsgroups	linux.kernel
Subject	Re: [RESEND PATCH v5 00/16] eeprom: at24: Add OF device ID table
Date	2017-08-30 18:20 +0200
Message-ID	<ukdSG-28x-9@gated-at.bofh.it> (permalink)
References	(1 earlier) <u9kXx-7Zm-25@gated-at.bofh.it> <u9lAf-8rv-27@gated-at.bofh.it> <ujuLU-7II-13@gated-at.bofh.it> <ujKnE-lz-7@gated-at.bofh.it> <ujKnE-lz-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello Wolfram,

On Tue, Aug 29, 2017 at 10:48 AM, Wolfram Sang <wsa@the-dreams.de> wrote:
>
>> I don't have a DT based system at hand now, but I'll test it again and
>> let you know probably tomorrow.
>
> I will try again today, too. Thanks!
>

Ok, I had some time to do some tests again. I used an ARM Chromebook
(Exynos Peach Pi) that has an I2C touchpad (Atmel maXTouch).

Tested the following cases:

1) Driver without OF device ID table (only a I2C table with a
"maxtouch" entry) and DTS defining a device node with a
"atmel,maxtouch" compatible string. This is the case without any of
the patches in this series.

$ modinfo drivers/input/touchscreen/atmel_mxt_ts.ko | grep maxtouch
alias:          i2c:maxtouch

$ grep maxtouch /sys/devices/platform/soc/12e00000.i2c/i2c-8/8-004b/uevent
OF_COMPATIBLE_0=atmel,maxtouch
MODALIAS=i2c:maxtouch

2) Driver without OF device ID table (only a I2C table with a
"maxtouch" entry) and DTS defining a device node with a
"atmel,maxtouch", "generic,maxtouch" compatible string. This is the
case when platform maintainers merge the DTS patches without the
driver patch.

$ modinfo drivers/input/touchscreen/atmel_mxt_ts.ko | grep maxtouch
alias:          i2c:maxtouch

$ grep maxtouch /sys/devices/platform/soc/12e00000.i2c/i2c-8/8-004b/uevent
OF_COMPATIBLE_0=atmel,maxtouch
OF_COMPATIBLE_1=generic,maxtouch
MODALIAS=i2c:maxtouch

3) Driver with an OF device ID table (with a "generic,maxtouch" entry)
and DTS defining a device node with a "atmel,maxtouch" compatible
string. This is the case when the driver patch is merged without the
DTS patches.

$ modinfo drivers/input/touchscreen/atmel_mxt_ts.ko | grep maxtouch
alias:          of:N*T*Cgeneric,maxtouchC*
alias:          of:N*T*Cgeneric,maxtouch
alias:          i2c:maxtouch

$ grep maxtouch /sys/devices/platform/soc/12e00000.i2c/i2c-8/8-004b/uevent
OF_COMPATIBLE_0=atmel,maxtouch
MODALIAS=i2c:maxtouch

4) Driver with an OF device ID table (with a "generic,maxtouch" entry)
and DTS defining a device node with a "atmel,maxtouch",
"generic,maxtouch" compatible string. This is the case when both the
DTS and driver patches are merged.

$ modinfo drivers/input/touchscreen/atmel_mxt_ts.ko | grep maxtouch
alias:          of:N*T*Cgeneric,maxtouchC*
alias:          of:N*T*Cgeneric,maxtouch
alias:          i2c:maxtouch

$ grep maxtouch /sys/devices/platform/soc/12e00000.i2c/i2c-8/8-004b/uevent
OF_COMPATIBLE_0=atmel,maxtouch
OF_COMPATIBLE_1=generic,maxtouch
MODALIAS=i2c:maxtouch

For all cases module autoload, driver probe and evtest worked for me.

You said that (3) doesn't work but I don't understand why is failing
for you. Probably I'm missing something.

Best regards,
Javier

Thread

Re: [RESEND PATCH v5 00/16] eeprom: at24: Add OF device ID table Wolfram Sang <wsa@the-dreams.de> - 2017-08-28 18:10 +0200
  Re: [RESEND PATCH v5 00/16] eeprom: at24: Add OF device ID table Wolfram Sang <wsa@the-dreams.de> - 2017-08-29 10:50 +0200
    Re: [RESEND PATCH v5 00/16] eeprom: at24: Add OF device ID table Javier Martinez Canillas <javier@dowhile0.org> - 2017-08-30 18:20 +0200
      Re: [RESEND PATCH v5 00/16] eeprom: at24: Add OF device ID table Wolfram Sang <wsa@the-dreams.de> - 2017-08-30 19:50 +0200
        Re: [RESEND PATCH v5 00/16] eeprom: at24: Add OF device ID table Javier Martinez Canillas <javier@dowhile0.org> - 2017-08-30 22:00 +0200
          Re: [RESEND PATCH v5 00/16] eeprom: at24: Add OF device ID table Geert Uytterhoeven <geert@linux-m68k.org> - 2017-08-30 22:20 +0200
            Re: [RESEND PATCH v5 00/16] eeprom: at24: Add OF device ID table Javier Martinez Canillas <javier@dowhile0.org> - 2017-08-30 23:00 +0200
  Re: [RESEND PATCH v5 00/16] eeprom: at24: Add OF device ID table Javier Martinez Canillas <javier@dowhile0.org> - 2017-08-29 10:50 +0200

csiph-web