Re: [RESEND PATCH v5 00/16] eeprom: at24: Add OF device ID table

From	Wolfram Sang <wsa@the-dreams.de>
Newsgroups	linux.kernel
Subject	Re: [RESEND PATCH v5 00/16] eeprom: at24: Add OF device ID table
Date	2017-08-28 18:10 +0200
Message-ID	<ujuLU-7II-13@gated-at.bofh.it> (permalink)
References	<tSI9P-68f-3@gated-at.bofh.it> <u9kXx-7Zm-25@gated-at.bofh.it> <u9lAf-8rv-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

> > But there is a dependency, no? If I apply the driver patch,
> > non-converted device trees will not find their eeproms anymore. So, I
> 
> I don't think that's correct. If you apply this patch before the DTS
> changes, the driver will still match using the I2C device ID table
> like it has been doing it until today.

My tests do not confirm this. If I add a node with a "renesas,24c01"
compatible to my board, it works before your patch, but not after. If I
change it to "atmel,24c01" it works even after your patch. I haven't
looked into it, though, maybe i2c_of_match_device_sysfs() is stepping on
our foots here?

Did you test and did it work for you?

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [RESEND PATCH v5 00/16] eeprom: at24: Add OF device ID table Wolfram Sang <wsa@the-dreams.de> - 2017-08-28 18:10 +0200
  Re: [RESEND PATCH v5 00/16] eeprom: at24: Add OF device ID table Wolfram Sang <wsa@the-dreams.de> - 2017-08-29 10:50 +0200
    Re: [RESEND PATCH v5 00/16] eeprom: at24: Add OF device ID table Javier Martinez Canillas <javier@dowhile0.org> - 2017-08-30 18:20 +0200
      Re: [RESEND PATCH v5 00/16] eeprom: at24: Add OF device ID table Wolfram Sang <wsa@the-dreams.de> - 2017-08-30 19:50 +0200
        Re: [RESEND PATCH v5 00/16] eeprom: at24: Add OF device ID table Javier Martinez Canillas <javier@dowhile0.org> - 2017-08-30 22:00 +0200
          Re: [RESEND PATCH v5 00/16] eeprom: at24: Add OF device ID table Geert Uytterhoeven <geert@linux-m68k.org> - 2017-08-30 22:20 +0200
            Re: [RESEND PATCH v5 00/16] eeprom: at24: Add OF device ID table Javier Martinez Canillas <javier@dowhile0.org> - 2017-08-30 23:00 +0200
  Re: [RESEND PATCH v5 00/16] eeprom: at24: Add OF device ID table Javier Martinez Canillas <javier@dowhile0.org> - 2017-08-29 10:50 +0200

csiph-web