Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1723388

Re: [PATCH v2] pwm_bl: Fix overflow condition

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Aug 29, 2017 at 01:34:34PM -0700, Derek Basehore wrote:
> This fixes an overflow condition that can happen with high max
> brightness and period values in compute_duty_cycle. This fixes it by
> using a 64 bit variable for computing the duty cycle.
> 
> Signed-off-by: Derek Basehore <dbasehore@chromium.org>
> ---
>  drivers/video/backlight/pwm_bl.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)

I'm still confused by the brightness-levels-scale comment in the other
thread, but this looks like a good fix for a potential overflow so:

Acked-by: Thierry Reding <thierry.reding@gmail.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] pwm_bl: Fix overflow condition Derek Basehore <dbasehore@chromium.org> - 2017-08-29 22:40 +0200
  Re: [PATCH v2] pwm_bl: Fix overflow condition Brian Norris <briannorris@chromium.org> - 2017-08-29 22:50 +0200
  Re: [PATCH v2] pwm_bl: Fix overflow condition Thierry Reding <thierry.reding@gmail.com> - 2017-08-30 16:30 +0200
    Re: [PATCH v2] pwm_bl: Fix overflow condition Brian Norris <briannorris@chromium.org> - 2017-08-30 18:30 +0200
  Re: [PATCH v2] pwm_bl: Fix overflow condition Lee Jones <lee.jones@linaro.org> - 2017-09-04 17:20 +0200

csiph-web