Re: [PATCH] fsnotify: make dnotify_fsnotify_ops const

Path	csiph.com!feeder.erje.net!2.eu.feeder.erje.net!news.unit0.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Jan Kara <jack@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH] fsnotify: make dnotify_fsnotify_ops const
Date	Wed, 30 Aug 2017 16:10:03 +0200
Message-ID	<ukbQT-R3-23@gated-at.bofh.it> (permalink)
References	<ukarM-8kx-13@gated-at.bofh.it>
X-Original-To	Bhumika Goyal <bhumirks@gmail.com>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.24 (2015-08-30)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	32
Organization	linux.* mail to news gateway
X-Original-Cc	julia.lawall@lip6.fr, jack@suse.cz, amir73il@gmail.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Wed, 30 Aug 2017 16:03:05 +0200
X-Original-Message-ID	<20170830140305.GA5462@quack2.suse.cz>
X-Original-References	<1504096742-12621-1-git-send-email-bhumirks@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1723362

Show key headers only | View raw

On Wed 30-08-17 18:09:02, Bhumika Goyal wrote:
> Make this const as it is never modified.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

Thanks. Added to my tree.

								Honza

> ---
>  fs/notify/dnotify/dnotify.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/notify/dnotify/dnotify.c b/fs/notify/dnotify/dnotify.c
> index 2430a04..cba3283 100644
> --- a/fs/notify/dnotify/dnotify.c
> +++ b/fs/notify/dnotify/dnotify.c
> @@ -133,7 +133,7 @@ static void dnotify_free_mark(struct fsnotify_mark *fsn_mark)
>  	kmem_cache_free(dnotify_mark_cache, dn_mark);
>  }
>  
> -static struct fsnotify_ops dnotify_fsnotify_ops = {
> +static const struct fsnotify_ops dnotify_fsnotify_ops = {
>  	.handle_event = dnotify_handle_event,
>  	.free_mark = dnotify_free_mark,
>  };
> -- 
> 1.9.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] fsnotify: make dnotify_fsnotify_ops const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-30 14:40 +0200
  Re: [PATCH] fsnotify: make dnotify_fsnotify_ops const Jan Kara <jack@suse.cz> - 2017-08-30 16:10 +0200

csiph-web