Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1723362

Re: [PATCH] fsnotify: make dnotify_fsnotify_ops const

From Jan Kara <jack@suse.cz>
Newsgroups linux.kernel
Subject Re: [PATCH] fsnotify: make dnotify_fsnotify_ops const
Date 2017-08-30 16:10 +0200
Message-ID <ukbQT-R3-23@gated-at.bofh.it> (permalink)
References <ukarM-8kx-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed 30-08-17 18:09:02, Bhumika Goyal wrote:
> Make this const as it is never modified.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

Thanks. Added to my tree.

								Honza

> ---
>  fs/notify/dnotify/dnotify.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/notify/dnotify/dnotify.c b/fs/notify/dnotify/dnotify.c
> index 2430a04..cba3283 100644
> --- a/fs/notify/dnotify/dnotify.c
> +++ b/fs/notify/dnotify/dnotify.c
> @@ -133,7 +133,7 @@ static void dnotify_free_mark(struct fsnotify_mark *fsn_mark)
>  	kmem_cache_free(dnotify_mark_cache, dn_mark);
>  }
>  
> -static struct fsnotify_ops dnotify_fsnotify_ops = {
> +static const struct fsnotify_ops dnotify_fsnotify_ops = {
>  	.handle_event = dnotify_handle_event,
>  	.free_mark = dnotify_free_mark,
>  };
> -- 
> 1.9.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] fsnotify: make dnotify_fsnotify_ops const Bhumika Goyal <bhumirks@gmail.com> - 2017-08-30 14:40 +0200
  Re: [PATCH] fsnotify: make dnotify_fsnotify_ops const Jan Kara <jack@suse.cz> - 2017-08-30 16:10 +0200

csiph-web