Re: [PATCH 01/16] ashmem: switch to ->read_iter

From	Christoph Hellwig <hch@lst.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 01/16] ashmem: switch to ->read_iter
Date	2017-09-01 12:30 +0200
Message-ID	<ukRn3-2DU-9@gated-at.bofh.it> (permalink)
References	<ukcMW-1sy-9@gated-at.bofh.it> <ukcMW-1sy-13@gated-at.bofh.it> <ukd6h-1Bo-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Aug 30, 2017 at 04:28:55PM +0100, Al Viro wrote:
> On Wed, Aug 30, 2017 at 04:59:52PM +0200, Christoph Hellwig wrote:
> > And use the proper VFS helper for using the backing file.
> 
> Actually, I wonder if that update of ->f_pos of the underlying file is
> correct.  That's unrelated to this patch, but might be worth sorting
> out while we are at it.

Sure, I'll add that.  If ashmem_mutex wasn't a global lock we could
just as easily keep it locked, but I'll leave that to the android
folks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 01/16] ashmem: switch to ->read_iter Christoph Hellwig <hch@lst.de> - 2017-08-30 17:10 +0200
  Re: [PATCH 01/16] ashmem: switch to ->read_iter Al Viro <viro@ZenIV.linux.org.uk> - 2017-08-30 17:30 +0200
    Re: [PATCH 01/16] ashmem: switch to ->read_iter Christoph Hellwig <hch@lst.de> - 2017-09-01 12:30 +0200

csiph-web