Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1724653

Re: Converting struct timer_list callback argument to struct timer_list *

Show all headers | View raw

On Thu, Aug 31, 2017 at 1:13 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> On Wed, 30 Aug 2017, Kees Cook wrote:
>> Which gets me to here:
>>  747 files changed, 3363 insertions(+), 3410 deletions(-)
>>
>> And current builds with the forced casts removed show about 400 more
>> call sites to fix...
>
> That's a herculean task. Chapeau!

Coccinelle has helped a lot, but yeah, not a small conversion! :P

>> Does this look alright,
>
> Very well done. I like the temporary typecast trick.

Okay, good. Since there's no sensible type checking here already, it
didn't seem _worse_. :)

>> and should some of this go into -next right
>> now, just to get some of the clean-ups into the tree? (Basically,
>> everything before "timer: Temporarily explicitly cast all callback
>> functions")
>
> Yes, just get that part in now.

Okay, I've sent the first 31 patches your way just now. I'll keep
grinding away at the rest...

-Kees

-- 
Kees Cook
Pixel Security

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Converting struct timer_list callback argument to struct timer_list * Kees Cook <keescook@chromium.org> - 2017-08-31 01:40 +0200
  Re: Converting struct timer_list callback argument to struct timer_list  * Thomas Gleixner <tglx@linutronix.de> - 2017-08-31 22:20 +0200
    Re: Converting struct timer_list callback argument to struct  timer_list * Kees Cook <keescook@chromium.org> - 2017-09-01 01:40 +0200
  Re: Converting struct timer_list callback argument to struct  timer_list * Christoph Hellwig <hch@infradead.org> - 2017-09-01 12:10 +0200
    Re: Converting struct timer_list callback argument to struct timer_list  * Thomas Gleixner <tglx@linutronix.de> - 2017-09-01 12:30 +0200
      Re: Converting struct timer_list callback argument to struct  timer_list * Christoph Hellwig <hch@infradead.org> - 2017-09-01 12:50 +0200
        Re: Converting struct timer_list callback argument to struct  timer_list * Kees Cook <keescook@chromium.org> - 2017-09-01 18:30 +0200
          Re: Converting struct timer_list callback argument to struct  timer_list * Christoph Hellwig <hch@infradead.org> - 2017-09-03 09:40 +0200
            Re: Converting struct timer_list callback argument to struct  timer_list * Kees Cook <keescook@chromium.org> - 2017-09-03 22:20 +0200
              Re: Converting struct timer_list callback argument to struct  timer_list * Christoph Hellwig <hch@infradead.org> - 2017-09-04 08:10 +0200

csiph-web