Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1723041

Re: [PATCH] Staging:android:ion:ion.c : Using WARN_ON() rather than BUG()

Show all headers | View raw

On Wed, Aug 30, 2017 at 12:51:02AM +0530, harsha wrote:
> Fixes checkpatch.pl warning: Use WARN_ON() rather than BUG_ON() and BUG()
> 
> Signed-off-by: harsha <harshasharmaiitr@gmail.com>
> ---
>  drivers/staging/android/ion/ion.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
> index 93e2c90..a2d36b3 100644
> --- a/drivers/staging/android/ion/ion.c
> +++ b/drivers/staging/android/ion/ion.c
> @@ -66,7 +66,7 @@ static void ion_buffer_add(struct ion_device *dev,
>  			p = &(*p)->rb_right;
>  		} else {
>  			pr_err("%s: buffer already found.", __func__);
> -			BUG();
> +			WARN_ON();
>  		}
>  	}
>  

As you did not do anything different from the last submission where I
said this patch was not correct, I'm guessing that you don't want any
feedback.  So I'll go add you to my kill-file now and just ignore your
emails, as obviously, you are ignoring mine :(

good luck!

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] Staging:android:ion:ion.c : Using WARN_ON() rather than BUG() harsha <harshasharmaiitr@gmail.com> - 2017-08-29 21:30 +0200
  [PATCH] Staging:android:ion:ion.c : Using WARN_ON() rather than BUG() harsha <harshasharmaiitr@gmail.com> - 2017-08-29 21:30 +0200
    Re: [PATCH] Staging:android:ion:ion.c : Using WARN_ON() rather than  BUG() Greg KH <gregkh@linuxfoundation.org> - 2017-08-30 08:00 +0200
  Re: [PATCH] Staging:android:ion:ion.c : Using WARN_ON() rather than  BUG() Dan Carpenter <dan.carpenter@oracle.com> - 2017-08-29 22:40 +0200

csiph-web