Re: [PATCH] Staging:android:ion:ion.c : Using WARN_ON() rather than BUG()

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Staging:android:ion:ion.c : Using WARN_ON() rather than BUG()
Date	2017-08-29 22:40 +0200
Message-ID	<ujVsJ-7lK-5@gated-at.bofh.it> (permalink)
References	<ujUmZ-6IJ-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Aug 30, 2017 at 12:51:01AM +0530, harsha wrote:
> Hi,
> harsha,  this is my real name.

That's your full name that you use to sign legal documents?  No last
name? No capital letter at the beginning?

> There is no need to call BUG() over here as this error is not very basic and BUG() tends to bring the system down so calling WARN_ON() is preferable.

In the original code the kernel will call BUG() once but in the new code
it will spam the dmesg forever until you pull the power cord.  There is
no improvement.

regards,
dan carpenter

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Staging:android:ion:ion.c : Using WARN_ON() rather than BUG() harsha <harshasharmaiitr@gmail.com> - 2017-08-29 21:30 +0200
  [PATCH] Staging:android:ion:ion.c : Using WARN_ON() rather than BUG() harsha <harshasharmaiitr@gmail.com> - 2017-08-29 21:30 +0200
    Re: [PATCH] Staging:android:ion:ion.c : Using WARN_ON() rather than  BUG() Greg KH <gregkh@linuxfoundation.org> - 2017-08-30 08:00 +0200
  Re: [PATCH] Staging:android:ion:ion.c : Using WARN_ON() rather than  BUG() Dan Carpenter <dan.carpenter@oracle.com> - 2017-08-29 22:40 +0200

csiph-web