Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1721737

Re: [PATCH v5 1/2] sched/clock: interface to allow timestamps early in boot

From Thomas Gleixner <tglx@linutronix.de>
Newsgroups linux.kernel
Subject Re: [PATCH v5 1/2] sched/clock: interface to allow timestamps early in boot
Date 2017-08-28 17:20 +0200
Message-ID <ujtZy-7cf-81@gated-at.bofh.it> (permalink)
References <uhKL9-5jQ-29@gated-at.bofh.it> <uhKL9-5jQ-27@gated-at.bofh.it> <uivK2-1z1-9@gated-at.bofh.it> <ujt3s-6CP-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Mon, 28 Aug 2017, Pasha Tatashin wrote:
> > > +/*
> > > + * Called once during to boot to initialize boot time.
> > > + */
> > > +void read_boot_clock64(struct timespec64 *ts)
> > 
> > And because its called only once, it does not need to be marked __init()
> > and must be kept around forever, right?
> 
> This is because every other architecture implements read_boot_clock64()
> without __init: arm, s390. Beside, the original weak stub does not have __init
> macro. So, I can certainly try to add it for x86, but I am not sure what is
> the behavior once __init section is gone, but weak implementation stays.

And what about fixing that everywhere?

Just because something is wrong, it does not mean that it needs to be
proliferated.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v5 1/2] sched/clock: interface to allow timestamps early  in boot Thomas Gleixner <tglx@linutronix.de> - 2017-08-26 01:00 +0200
  Re: [PATCH v5 1/2] sched/clock: interface to allow timestamps early  in boot Pasha Tatashin <pasha.tatashin@oracle.com> - 2017-08-28 16:20 +0200
    Re: [PATCH v5 1/2] sched/clock: interface to allow timestamps early  in boot Thomas Gleixner <tglx@linutronix.de> - 2017-08-28 17:20 +0200
      Re: [PATCH v5 1/2] sched/clock: interface to allow timestamps early  in boot Pasha Tatashin <pasha.tatashin@oracle.com> - 2017-08-28 19:50 +0200
    Re: [PATCH v5 1/2] sched/clock: interface to allow timestamps early  in boot Thomas Gleixner <tglx@linutronix.de> - 2017-08-28 17:20 +0200
      Re: [PATCH v5 1/2] sched/clock: interface to allow timestamps early  in boot Pasha Tatashin <pasha.tatashin@oracle.com> - 2017-08-28 20:10 +0200

csiph-web