Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1721738

Re: [PATCH v5 1/2] sched/clock: interface to allow timestamps early in boot

From Thomas Gleixner <tglx@linutronix.de>
Newsgroups linux.kernel
Subject Re: [PATCH v5 1/2] sched/clock: interface to allow timestamps early in boot
Date 2017-08-28 17:20 +0200
Message-ID <ujtZy-7cf-77@gated-at.bofh.it> (permalink)
References <uhKL9-5jQ-29@gated-at.bofh.it> <uhKL9-5jQ-27@gated-at.bofh.it> <uivK2-1z1-9@gated-at.bofh.it> <ujt3s-6CP-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, 28 Aug 2017, Pasha Tatashin wrote:
> This makes sense. Changing order in timekeeping_init(void) should take care of
> this:
> 
> Change to:
> 
> void __init timekeeping_init(void)
> {
> 	/*
> 	 * We must determine boot timestamp before getting current  	
> 	 * persistent clock value, because implementation of
> 	 * read_boot_clock64() might also call the persistent
> 	 * clock, and a leap second may occur.
> 	 */
> 
> 	read_boot_clock64(&boot);
> 	...
> 	read_persistent_clock64(&now);

No. That's the same crap just the other way round.

s390 can do that, because the boot timestamp is correlated with the
persistent clock. Your's not so much.

Thanks,

	tglx

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH v5 1/2] sched/clock: interface to allow timestamps early  in boot Thomas Gleixner <tglx@linutronix.de> - 2017-08-26 01:00 +0200
  Re: [PATCH v5 1/2] sched/clock: interface to allow timestamps early  in boot Pasha Tatashin <pasha.tatashin@oracle.com> - 2017-08-28 16:20 +0200
    Re: [PATCH v5 1/2] sched/clock: interface to allow timestamps early  in boot Thomas Gleixner <tglx@linutronix.de> - 2017-08-28 17:20 +0200
      Re: [PATCH v5 1/2] sched/clock: interface to allow timestamps early  in boot Pasha Tatashin <pasha.tatashin@oracle.com> - 2017-08-28 19:50 +0200
    Re: [PATCH v5 1/2] sched/clock: interface to allow timestamps early  in boot Thomas Gleixner <tglx@linutronix.de> - 2017-08-28 17:20 +0200
      Re: [PATCH v5 1/2] sched/clock: interface to allow timestamps early  in boot Pasha Tatashin <pasha.tatashin@oracle.com> - 2017-08-28 20:10 +0200

csiph-web