Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1721446

Re: [PATCH net-next v2 05/14] net: mvpp2: do not force the link mode

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Aug 28, 2017 at 09:51:52AM +0100, Russell King - ARM Linux wrote:
> On Mon, Aug 28, 2017 at 10:38:37AM +0200, Marcin Wojtas wrote:
> >
> > Can you be 100% sure that when using SGMII with PHY's (like Marvell
> > Alaska 88E1xxx series), is in-band link information always available?
> > I'd be very cautious with such assumption and use in-band management
> > only when set in the DT, like mvneta. I think phylib can properly can
> > do its work when MDIO connection is provided on the board.
> 
> There is another issue to be aware of: if you're wanting to use flow
> control autonegotiation, that is not carried across SGMII's in-band
> signalling.  If you want to use SGMII's in-band signalling for the
> duplex and speed information, you still need phylib's notification
> to properly set the flow control.
> 
> <plug>
> Switching mvpp2 to use phylink (which is needed for the 1G SFP slot on
> mcbin) will handle all this for you - dealing with both in-band and
> out-of-band negotiation methods, and combining them in the appropriate
> manner for the selected operation mode.
> </plug>

So probably the best move here is to remove this patch, and wait for the
phylink support in the PPv2 driver.

Thanks!
Antoine

-- 
Antoine Ténart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next v2 00/14] net: mvpp2: comphy configuration Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-25 17:00 +0200
  [PATCH net-next v2 02/14] phy: add the mvebu cp110 comphy driver Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-25 17:00 +0200
  [PATCH net-next v2 05/14] net: mvpp2: do not force the link mode Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-25 17:00 +0200
    Re: [PATCH net-next v2 05/14] net: mvpp2: do not force the link mode Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-08-26 00:50 +0200
      Re: [PATCH net-next v2 05/14] net: mvpp2: do not force the link mode Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-28 09:00 +0200
        Re: [PATCH net-next v2 05/14] net: mvpp2: do not force the link mode Marcin Wojtas <mw@semihalf.com> - 2017-08-28 10:40 +0200
          Re: [PATCH net-next v2 05/14] net: mvpp2: do not force the link mode Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-08-28 11:00 +0200
            Re: [PATCH net-next v2 05/14] net: mvpp2: do not force the link mode Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-28 11:50 +0200
              Re: [PATCH net-next v2 05/14] net: mvpp2: do not force the link mode Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-08-28 13:10 +0200
                Re: [PATCH net-next v2 05/14] net: mvpp2: do not force the link mode Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-28 13:40 +0200
  [PATCH net-next v2 12/14] arm64: dts: marvell: mcbin: add comphy references to Ethernet ports Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-25 17:00 +0200
  [PATCH net-next v2 06/14] net: mvpp2: simplify the link_event function Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-25 17:00 +0200
  [PATCH net-next v2 11/14] arm64: dts: marvell: add comphy nodes on cp110 master and slave Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-25 17:00 +0200
  [PATCH net-next v2 09/14] net: mvpp2: dynamic reconfiguration of the PHY mode Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-25 17:00 +0200
    Re: [PATCH net-next v2 09/14] net: mvpp2: dynamic reconfiguration of  the PHY mode Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-08-26 00:50 +0200
      Re: [PATCH net-next v2 09/14] net: mvpp2: dynamic reconfiguration of  the PHY mode Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-28 09:00 +0200
  [PATCH net-next v2 10/14] arm64: dts: marvell: extend the cp110 syscon register area length Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-25 17:00 +0200
  [PATCH net-next v2 04/14] net: mvpp2: initialize the comphy Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-25 17:00 +0200
  [PATCH net-next v2 13/14] arm64: dts: marvell: 7040-db: add comphy references to Ethernet ports Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-25 17:00 +0200
  [PATCH net-next v2 07/14] net: mvpp2: improve the link management function Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-25 17:00 +0200
  Re: [PATCH net-next v2 00/14] net: mvpp2: comphy configuration Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-25 18:00 +0200
  Re: [PATCH net-next v2 00/14] net: mvpp2: comphy configuration Andrew Lunn <andrew@lunn.ch> - 2017-08-25 18:00 +0200

csiph-web