Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1721065

Re: [PATCH net-next v2 09/14] net: mvpp2: dynamic reconfiguration of the PHY mode

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Russell,

On Fri, Aug 25, 2017 at 11:46:16PM +0100, Russell King - ARM Linux wrote:
> On Fri, Aug 25, 2017 at 04:48:16PM +0200, Antoine Tenart wrote:
> > This patch adds logic to reconfigure the comphy/gop when the link status
> > change at runtime. This is very useful on boards such as the mcbin which
> > have SFP and Ethernet ports connected to the same MAC port: depending on
> > what the user connects the driver will automatically reconfigure the
> > link mode.
> 
> This commit commentry needs updating - as I've already pointed out in
> the previous round, the need to reconfigure things has *nothing* to do
> with there being SFP and "Ethernet" ports present.  Hence, your commit
> message is entirely misleading.

That's right. I'll update the commit message.

Thanks!
Antoine

-- 
Antoine Ténart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next v2 00/14] net: mvpp2: comphy configuration Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-25 17:00 +0200
  [PATCH net-next v2 02/14] phy: add the mvebu cp110 comphy driver Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-25 17:00 +0200
  [PATCH net-next v2 05/14] net: mvpp2: do not force the link mode Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-25 17:00 +0200
    Re: [PATCH net-next v2 05/14] net: mvpp2: do not force the link mode Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-08-26 00:50 +0200
      Re: [PATCH net-next v2 05/14] net: mvpp2: do not force the link mode Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-28 09:00 +0200
        Re: [PATCH net-next v2 05/14] net: mvpp2: do not force the link mode Marcin Wojtas <mw@semihalf.com> - 2017-08-28 10:40 +0200
          Re: [PATCH net-next v2 05/14] net: mvpp2: do not force the link mode Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-08-28 11:00 +0200
            Re: [PATCH net-next v2 05/14] net: mvpp2: do not force the link mode Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-28 11:50 +0200
              Re: [PATCH net-next v2 05/14] net: mvpp2: do not force the link mode Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-08-28 13:10 +0200
                Re: [PATCH net-next v2 05/14] net: mvpp2: do not force the link mode Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-28 13:40 +0200
  [PATCH net-next v2 12/14] arm64: dts: marvell: mcbin: add comphy references to Ethernet ports Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-25 17:00 +0200
  [PATCH net-next v2 06/14] net: mvpp2: simplify the link_event function Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-25 17:00 +0200
  [PATCH net-next v2 11/14] arm64: dts: marvell: add comphy nodes on cp110 master and slave Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-25 17:00 +0200
  [PATCH net-next v2 09/14] net: mvpp2: dynamic reconfiguration of the PHY mode Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-25 17:00 +0200
    Re: [PATCH net-next v2 09/14] net: mvpp2: dynamic reconfiguration of  the PHY mode Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-08-26 00:50 +0200
      Re: [PATCH net-next v2 09/14] net: mvpp2: dynamic reconfiguration of  the PHY mode Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-28 09:00 +0200
  [PATCH net-next v2 10/14] arm64: dts: marvell: extend the cp110 syscon register area length Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-25 17:00 +0200
  [PATCH net-next v2 04/14] net: mvpp2: initialize the comphy Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-25 17:00 +0200
  [PATCH net-next v2 13/14] arm64: dts: marvell: 7040-db: add comphy references to Ethernet ports Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-25 17:00 +0200
  [PATCH net-next v2 07/14] net: mvpp2: improve the link management function Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-25 17:00 +0200
  Re: [PATCH net-next v2 00/14] net: mvpp2: comphy configuration Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-25 18:00 +0200
  Re: [PATCH net-next v2 00/14] net: mvpp2: comphy configuration Andrew Lunn <andrew@lunn.ch> - 2017-08-25 18:00 +0200

csiph-web