Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1722468
| From | tip-bot for Colin Ian King <tipbot@zytor.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [tip:x86/platform] x86/platform/intel-mid: Make several arrays static, to make code smaller |
| Date | 2017-08-29 15:20 +0200 |
| Message-ID | <ujOAW-37c-25@gated-at.bofh.it> (permalink) |
| References | <uipOi-6ni-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Commit-ID: 3308376a914b9c3f57a12072c063814403d983a8
Gitweb: http://git.kernel.org/tip/3308376a914b9c3f57a12072c063814403d983a8
Author: Colin Ian King <colin.king@canonical.com>
AuthorDate: Fri, 25 Aug 2017 17:32:06 +0100
Committer: Ingo Molnar <mingo@kernel.org>
CommitDate: Tue, 29 Aug 2017 13:30:16 +0200
x86/platform/intel-mid: Make several arrays static, to make code smaller
Don't populate arrays on the stack, instead make them static.
Makes the object code smaller by 76 bytes:
Before:
text data bss dec hex filename
4217 1540 128 5885 16fd arch/x86/platform/intel-mid/pwr.o
After:
text data bss dec hex filename
3981 1700 128 5809 16b1 arch/x86/platform/intel-mid/pwr.o
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Lukas Wunner <lukas@wunner.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: kernel-janitors@vger.kernel.org
Link: http://lkml.kernel.org/r/20170825163206.23250-1-colin.king@canonical.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/platform/intel-mid/pwr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/platform/intel-mid/pwr.c b/arch/x86/platform/intel-mid/pwr.c
index ef03852..49ec5b9 100644
--- a/arch/x86/platform/intel-mid/pwr.c
+++ b/arch/x86/platform/intel-mid/pwr.c
@@ -444,7 +444,7 @@ static int mid_set_initial_state(struct mid_pwr *pwr, const u32 *states)
static int pnw_set_initial_state(struct mid_pwr *pwr)
{
/* On Penwell SRAM must stay powered on */
- const u32 states[] = {
+ static const u32 states[] = {
0xf00fffff, /* PM_SSC(0) */
0xffffffff, /* PM_SSC(1) */
0xffffffff, /* PM_SSC(2) */
@@ -455,7 +455,7 @@ static int pnw_set_initial_state(struct mid_pwr *pwr)
static int tng_set_initial_state(struct mid_pwr *pwr)
{
- const u32 states[] = {
+ static const u32 states[] = {
0xffffffff, /* PM_SSC(0) */
0xffffffff, /* PM_SSC(1) */
0xffffffff, /* PM_SSC(2) */
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] x86/platform/intel-mid: make several arrays static, makes code smaller Colin King <colin.king@canonical.com> - 2017-08-25 18:40 +0200
Re: [PATCH] x86/platform/intel-mid: make several arrays static, makes code smaller Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-08-25 19:00 +0200
Re: [PATCH] x86/platform/intel-mid: make several arrays static, makes code smaller Lukas Wunner <lukas@wunner.de> - 2017-08-25 20:00 +0200
Re: [PATCH] x86/platform/intel-mid: make several arrays static, makes code smaller Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-08-25 20:00 +0200
Re: [PATCH] x86/platform/intel-mid: make several arrays static, makes code smaller Colin Ian King <colin.king@canonical.com> - 2017-08-25 20:20 +0200
[tip:x86/platform] x86/platform/intel-mid: Make several arrays static, to make code smaller tip-bot for Colin Ian King <tipbot@zytor.com> - 2017-08-29 15:20 +0200
csiph-web