Re: [PATCH V3] acpi: apei: clear error status before acknowledging the error

From	Borislav Petkov <bp@alien8.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH V3] acpi: apei: clear error status before acknowledging the error
Date	2017-08-29 10:20 +0200
Message-ID	<ujJUC-bY-17@gated-at.bofh.it> (permalink)
References	<ujvyj-80q-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Aug 28, 2017 at 10:53:41AM -0600, Tyler Baicar wrote:
> Currently we acknowledge errors before clearing the error status.
> This could cause a new error to be populated by firmware in-between
> the error acknowledgment and the error status clearing which would
> cause the second error's status to be cleared without being handled.
> So, clear the error status before acknowledging the errors.
> 
> Also, make sure to acknowledge the error if the error status read
> fails.
> 
> V3: Seperate check for -ENOENT return value
> 
> V2: Only send error ack if there was an error populated
>     Remove curly braces that are no longer needed
> 
> Signed-off-by: Tyler Baicar <tbaicar@codeaurora.org>
> ---
>  drivers/acpi/apei/ghes.c | 16 +++++++++-------
>  1 file changed, 9 insertions(+), 7 deletions(-)

Reviewed-by: Borislav Petkov <bp@suse.de>

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V3] acpi: apei: clear error status before acknowledging the error Tyler Baicar <tbaicar@codeaurora.org> - 2017-08-28 19:00 +0200
  Re: [PATCH V3] acpi: apei: clear error status before acknowledging  the error Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-08-28 19:10 +0200
    Re: [PATCH V3] acpi: apei: clear error status before acknowledging  the error Borislav Petkov <bp@suse.de> - 2017-08-28 19:20 +0200
      Re: [PATCH V3] acpi: apei: clear error status before acknowledging  the error Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-08-28 19:30 +0200
        Re: [PATCH V3] acpi: apei: clear error status before acknowledging  the error Borislav Petkov <bp@suse.de> - 2017-08-28 19:30 +0200
          Re: [PATCH V3] acpi: apei: clear error status before acknowledging  the error Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-08-28 19:50 +0200
            Re: [PATCH V3] acpi: apei: clear error status before acknowledging  the error Borislav Petkov <bp@suse.de> - 2017-08-28 20:30 +0200
              Re: [PATCH V3] acpi: apei: clear error status before acknowledging  the error Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-08-28 21:20 +0200
              Re: [PATCH V3] acpi: apei: clear error status before acknowledging  the error Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-08-28 21:20 +0200
  Re: [PATCH V3] acpi: apei: clear error status before acknowledging  the error Borislav Petkov <bp@alien8.de> - 2017-08-29 10:20 +0200

csiph-web