Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1720859

[PATCH 06/12] microblaze: make dma_cache_sync a no-op

Show all headers | View raw

microblaze does not implement DMA_ATTR_NON_CONSISTENT allocations, so it
doesn't make any sense to do any work in dma_cache_sync given that it
must be a no-op when dma_alloc_attrs returns coherent memory.

This also allows moving __dma_sync out of the microblaze asm/dma-mapping.h
and thus greatly reduce the amount of includes there.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 arch/microblaze/include/asm/dma-mapping.h | 34 -------------------------------
 arch/microblaze/kernel/dma.c              | 17 ++++++++++++++++
 2 files changed, 17 insertions(+), 34 deletions(-)

diff --git a/arch/microblaze/include/asm/dma-mapping.h b/arch/microblaze/include/asm/dma-mapping.h
index e15cd2f76e23..ad448e4aedb6 100644
--- a/arch/microblaze/include/asm/dma-mapping.h
+++ b/arch/microblaze/include/asm/dma-mapping.h
@@ -16,22 +16,6 @@
 #define _ASM_MICROBLAZE_DMA_MAPPING_H
 
 /*
- * See Documentation/DMA-API-HOWTO.txt and
- * Documentation/DMA-API.txt for documentation.
- */
-
-#include <linux/types.h>
-#include <linux/cache.h>
-#include <linux/mm.h>
-#include <linux/scatterlist.h>
-#include <linux/dma-debug.h>
-#include <asm/io.h>
-#include <asm/cacheflush.h>
-
-#define __dma_alloc_coherent(dev, gfp, size, handle)	NULL
-#define __dma_free_coherent(size, addr)		((void)0)
-
-/*
  * Available generic sets of operations
  */
 extern const struct dma_map_ops dma_direct_ops;
@@ -41,27 +25,9 @@ static inline const struct dma_map_ops *get_arch_dma_ops(struct bus_type *bus)
 	return &dma_direct_ops;
 }
 
-static inline void __dma_sync(unsigned long paddr,
-			      size_t size, enum dma_data_direction direction)
-{
-	switch (direction) {
-	case DMA_TO_DEVICE:
-	case DMA_BIDIRECTIONAL:
-		flush_dcache_range(paddr, paddr + size);
-		break;
-	case DMA_FROM_DEVICE:
-		invalidate_dcache_range(paddr, paddr + size);
-		break;
-	default:
-		BUG();
-	}
-}
-
 static inline void dma_cache_sync(struct device *dev, void *vaddr, size_t size,
 		enum dma_data_direction direction)
 {
-	BUG_ON(direction == DMA_NONE);
-	__dma_sync(virt_to_phys(vaddr), size, (int)direction);
 }
 
 #endif	/* _ASM_MICROBLAZE_DMA_MAPPING_H */
diff --git a/arch/microblaze/kernel/dma.c b/arch/microblaze/kernel/dma.c
index e45ada8fb006..621902f8b0a0 100644
--- a/arch/microblaze/kernel/dma.c
+++ b/arch/microblaze/kernel/dma.c
@@ -12,6 +12,7 @@
 #include <linux/dma-debug.h>
 #include <linux/export.h>
 #include <linux/bug.h>
+#include <asm/cacheflush.h>
 
 #define NOT_COHERENT_CACHE
 
@@ -51,6 +52,22 @@ static void dma_direct_free_coherent(struct device *dev, size_t size,
 #endif
 }
 
+static inline void __dma_sync(unsigned long paddr,
+			      size_t size, enum dma_data_direction direction)
+{
+	switch (direction) {
+	case DMA_TO_DEVICE:
+	case DMA_BIDIRECTIONAL:
+		flush_dcache_range(paddr, paddr + size);
+		break;
+	case DMA_FROM_DEVICE:
+		invalidate_dcache_range(paddr, paddr + size);
+		break;
+	default:
+		BUG();
+	}
+}
+
 static int dma_direct_map_sg(struct device *dev, struct scatterlist *sgl,
 			     int nents, enum dma_data_direction direction,
 			     unsigned long attrs)
-- 
2.11.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

refactor dma_cache_sync Christoph Hellwig <hch@lst.de> - 2017-08-27 18:20 +0200
  [PATCH 06/12] microblaze: make dma_cache_sync a no-op Christoph Hellwig <hch@lst.de> - 2017-08-27 18:20 +0200
  [PATCH 02/12] mips: don't use dma_cache_sync to implement fd_cacheflush Christoph Hellwig <hch@lst.de> - 2017-08-27 18:20 +0200
  [PATCH 05/12] ia64: make dma_cache_sync a no-op Christoph Hellwig <hch@lst.de> - 2017-08-27 18:20 +0200
  [PATCH 07/12] mn10300: make dma_cache_sync a no-op Christoph Hellwig <hch@lst.de> - 2017-08-27 18:20 +0200
  [PATCH 11/12] sh: make dma_cache_sync a no-op Christoph Hellwig <hch@lst.de> - 2017-08-27 18:20 +0200
  [PATCH 09/12] unicore32: make dma_cache_sync a no-op Christoph Hellwig <hch@lst.de> - 2017-08-27 18:20 +0200
  [PATCH 10/12] xtensa: make dma_cache_sync a no-op Christoph Hellwig <hch@lst.de> - 2017-08-27 18:20 +0200
  [PATCH 08/12] powerpc: make dma_cache_sync a no-op Christoph Hellwig <hch@lst.de> - 2017-08-27 18:20 +0200
  [PATCH 01/12] floppy: consolidate the dummy fd_cacheflush definition Christoph Hellwig <hch@lst.de> - 2017-08-27 18:20 +0200
  [PATCH 03/12] frv: make dma_cache_sync a no-op Christoph Hellwig <hch@lst.de> - 2017-08-27 18:20 +0200
  [PATCH 12/12] dma-mapping: turn dma_cache_sync into a dma_map_ops method Christoph Hellwig <hch@lst.de> - 2017-08-27 18:20 +0200
    Re: [PATCH 12/12] dma-mapping: turn dma_cache_sync into a dma_map_ops method Geert Uytterhoeven <geert@linux-m68k.org> - 2017-08-28 08:30 +0200
  [PATCH 04/12] x86: make dma_cache_sync a no-op Christoph Hellwig <hch@lst.de> - 2017-08-27 18:20 +0200
    Re: [PATCH 04/12] x86: make dma_cache_sync a no-op Thomas Gleixner <tglx@linutronix.de> - 2017-08-31 16:10 +0200

csiph-web