Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1720861

[PATCH 05/12] ia64: make dma_cache_sync a no-op

Show all headers | View raw

ia64 does not implement DMA_ATTR_NON_CONSISTENT allocations, so it doesn't
make any sense to do any work in dma_cache_sync given that it must be a
no-op when dma_alloc_attrs returns coherent memory.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 arch/ia64/include/asm/dma-mapping.h | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/arch/ia64/include/asm/dma-mapping.h b/arch/ia64/include/asm/dma-mapping.h
index 3ce5ab4339f3..99dfc1aa9d3c 100644
--- a/arch/ia64/include/asm/dma-mapping.h
+++ b/arch/ia64/include/asm/dma-mapping.h
@@ -48,11 +48,6 @@ static inline void
 dma_cache_sync (struct device *dev, void *vaddr, size_t size,
 	enum dma_data_direction dir)
 {
-	/*
-	 * IA-64 is cache-coherent, so this is mostly a no-op.  However, we do need to
-	 * ensure that dma_cache_sync() enforces order, hence the mb().
-	 */
-	mb();
 }
 
 #endif /* _ASM_IA64_DMA_MAPPING_H */
-- 
2.11.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

refactor dma_cache_sync Christoph Hellwig <hch@lst.de> - 2017-08-27 18:20 +0200
  [PATCH 06/12] microblaze: make dma_cache_sync a no-op Christoph Hellwig <hch@lst.de> - 2017-08-27 18:20 +0200
  [PATCH 02/12] mips: don't use dma_cache_sync to implement fd_cacheflush Christoph Hellwig <hch@lst.de> - 2017-08-27 18:20 +0200
  [PATCH 05/12] ia64: make dma_cache_sync a no-op Christoph Hellwig <hch@lst.de> - 2017-08-27 18:20 +0200
  [PATCH 07/12] mn10300: make dma_cache_sync a no-op Christoph Hellwig <hch@lst.de> - 2017-08-27 18:20 +0200
  [PATCH 11/12] sh: make dma_cache_sync a no-op Christoph Hellwig <hch@lst.de> - 2017-08-27 18:20 +0200
  [PATCH 09/12] unicore32: make dma_cache_sync a no-op Christoph Hellwig <hch@lst.de> - 2017-08-27 18:20 +0200
  [PATCH 10/12] xtensa: make dma_cache_sync a no-op Christoph Hellwig <hch@lst.de> - 2017-08-27 18:20 +0200
  [PATCH 08/12] powerpc: make dma_cache_sync a no-op Christoph Hellwig <hch@lst.de> - 2017-08-27 18:20 +0200
  [PATCH 01/12] floppy: consolidate the dummy fd_cacheflush definition Christoph Hellwig <hch@lst.de> - 2017-08-27 18:20 +0200
  [PATCH 03/12] frv: make dma_cache_sync a no-op Christoph Hellwig <hch@lst.de> - 2017-08-27 18:20 +0200
  [PATCH 12/12] dma-mapping: turn dma_cache_sync into a dma_map_ops method Christoph Hellwig <hch@lst.de> - 2017-08-27 18:20 +0200
    Re: [PATCH 12/12] dma-mapping: turn dma_cache_sync into a dma_map_ops method Geert Uytterhoeven <geert@linux-m68k.org> - 2017-08-28 08:30 +0200
  [PATCH 04/12] x86: make dma_cache_sync a no-op Christoph Hellwig <hch@lst.de> - 2017-08-27 18:20 +0200
    Re: [PATCH 04/12] x86: make dma_cache_sync a no-op Thomas Gleixner <tglx@linutronix.de> - 2017-08-31 16:10 +0200

csiph-web