Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1720422
| From | Thomas Gleixner <tglx@linutronix.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [patch 15/41] x86/idt: Remove tracing idt completely |
| Date | 2017-08-25 23:30 +0200 |
| Message-ID | <uiukW-Oo-5@gated-at.bofh.it> (permalink) |
| References | <uikvf-2YQ-3@gated-at.bofh.it> <uikEX-3hj-61@gated-at.bofh.it> <uiubg-L8-17@gated-at.bofh.it> <uiukW-Oo-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, 25 Aug 2017, Thomas Gleixner wrote: > On Fri, 25 Aug 2017, Steven Rostedt wrote: > > On Fri, 25 Aug 2017 12:31:18 +0200 > > Thomas Gleixner <tglx@linutronix.de> wrote: > > > > > No more users of the tracing idt. All exception tracepoints have been moved > > > into the regular handlers. Get rid of the mess which shouldn't have been > > > created in the first place. > > > > > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > > > --- > > > arch/x86/entry/entry_32.S | 12 ----- > > > arch/x86/entry/entry_64.S | 13 ------ > > > arch/x86/include/asm/desc.h | 82 ++------------------------------------ > > > arch/x86/include/asm/entry_arch.h | 14 ++---- > > > arch/x86/include/asm/hw_irq.h | 20 --------- > > > arch/x86/include/asm/segment.h | 3 - > > > arch/x86/kernel/tracepoint.c | 43 ------------------- > > > arch/x86/kernel/traps.c | 6 -- > > > 8 files changed, 14 insertions(+), 179 deletions(-) > > > > > --- a/arch/x86/include/asm/entry_arch.h > > > +++ b/arch/x86/include/asm/entry_arch.h > > > @@ -13,20 +13,16 @@ > > > BUILD_INTERRUPT(reschedule_interrupt,RESCHEDULE_VECTOR) > > > BUILD_INTERRUPT(call_function_interrupt,CALL_FUNCTION_VECTOR) > > > BUILD_INTERRUPT(call_function_single_interrupt,CALL_FUNCTION_SINGLE_VECTOR) > > > -BUILD_INTERRUPT3(irq_move_cleanup_interrupt, IRQ_MOVE_CLEANUP_VECTOR, > > > - smp_irq_move_cleanup_interrupt) > > > -BUILD_INTERRUPT3(reboot_interrupt, REBOOT_VECTOR, smp_reboot_interrupt) > > > +BUILD_INTERRUPT(irq_move_cleanup_interrupt, IRQ_MOVE_CLEANUP_VECTOR) > > > +BUILD_INTERRUPT(reboot_interrupt, REBOOT_VECTOR) > > > #endif > > > > > > BUILD_INTERRUPT(x86_platform_ipi, X86_PLATFORM_IPI_VECTOR) > > > > > > #ifdef CONFIG_HAVE_KVM > > > -BUILD_INTERRUPT3(kvm_posted_intr_ipi, POSTED_INTR_VECTOR, > > > - smp_kvm_posted_intr_ipi) > > > -BUILD_INTERRUPT3(kvm_posted_intr_wakeup_ipi, POSTED_INTR_WAKEUP_VECTOR, > > > - smp_kvm_posted_intr_wakeup_ipi) > > > -BUILD_INTERRUPT3(kvm_posted_intr_nested_ipi, POSTED_INTR_NESTED_VECTOR, > > > - smp_kvm_posted_intr_nested_ipi) > > > +BUILD_INTERRUPT(kvm_posted_intr_ipi, POSTED_INTR_VECTOR) > > > +BUILD_INTERRUPT(kvm_posted_intr_wakeup_ipi, POSTED_INTR_WAKEUP_VECTOR) > > > +BUILD_INTERRUPT(kvm_posted_intr_nested_ipi, POSTED_INTR_NESTED_VECTOR) > > > #endif > > > > > > This looks like a different change than what is specified in the change > > log. It looks like a clean up. Shouldn't it be a separate patch? > > Let me split it up. OTOH, the BUILD_INTERRUPT3 users were explicit to avoid the TRACE_BUILD_INTERRUPT() extra which was hidden behind BUILD_INTERRUPT. So yes, it's a cleanup, but related. Thanks, tglx
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[patch 00/41] x86: Cleanup IDT code Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
[patch 01/41] x86/irq: Remove vector_used_by_percpu_irq() Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
[patch 26/41] x86/idt: Consolidate IDT invalidation Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
[patch 06/41] x86/traps: Simplify pagefault tracing logic Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
Re: [patch 06/41] x86/traps: Simplify pagefault tracing logic Andy Lutomirski <luto@kernel.org> - 2017-08-25 17:00 +0200
Re: [patch 06/41] x86/traps: Simplify pagefault tracing logic Steven Rostedt <rostedt@goodmis.org> - 2017-08-25 17:20 +0200
Re: [patch 06/41] x86/traps: Simplify pagefault tracing logic Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 17:20 +0200
[patch 07/41] x86/apic: Remove the duplicated tracing version of local_timer_interrupt Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
Re: [patch 07/41] x86/apic: Remove the duplicated tracing version of local_timer_interrupt Steven Rostedt <rostedt@goodmis.org> - 2017-08-25 17:30 +0200
[patch 14/41] x86/smp: Use static key for reschedule interrupt tracing Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
Re: [patch 14/41] x86/smp: Use static key for reschedule interrupt tracing Steven Rostedt <rostedt@goodmis.org> - 2017-08-25 21:50 +0200
Re: [patch 14/41] x86/smp: Use static key for reschedule interrupt tracing Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 22:10 +0200
Re: [patch 14/41] x86/smp: Use static key for reschedule interrupt tracing Steven Rostedt <rostedt@goodmis.org> - 2017-08-25 23:20 +0200
[patch 05/41] x86/tracing: Introduce a static key for exception tracing Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
Re: [patch 05/41] x86/tracing: Introduce a static key for exception tracing Steven Rostedt <rostedt@goodmis.org> - 2017-08-25 17:30 +0200
[patch 10/41] x86/apic: Remove the duplicated tracing versions of interrupts Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
Re: [patch 10/41] x86/apic: Remove the duplicated tracing versions of interrupts Steven Rostedt <rostedt@goodmis.org> - 2017-08-25 17:50 +0200
Re: [patch 10/41] x86/apic: Remove the duplicated tracing versions of interrupts Peter Zijlstra <peterz@infradead.org> - 2017-08-28 10:00 +0200
[patch 11/41] x86/irqwork: Get rid of duplicated tracing interrupt code Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
Re: [patch 11/41] x86/irqwork: Get rid of duplicated tracing interrupt code Steven Rostedt <rostedt@goodmis.org> - 2017-08-25 18:00 +0200
[patch 23/41] x86/idt: Create file for IDT related code Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
[patch 03/41] x86/irq: Move ifdeffery to header file Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
Re: [patch 03/41] x86/irq: Move ifdeffery to header file Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 14:50 +0200
[patch 24/41] x86/idt: Move 32bit idt_descr to C code Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
[patch 16/41] x86/tracing: Disentangle pagefault and resched IPI tracing key Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
[patch 09/41] x86/irq: Get rid of duplicated trace_x86_platform_ipi() code Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
Re: [patch 09/41] x86/irq: Get rid of duplicated trace_x86_platform_ipi() code Steven Rostedt <rostedt@goodmis.org> - 2017-08-25 17:50 +0200
[patch 12/41] x86/mce: Remove duplicated tracing interrupt code Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
Re: [patch 12/41] x86/mce: Remove duplicated tracing interrupt code Steven Rostedt <rostedt@goodmis.org> - 2017-08-25 18:10 +0200
Re: [patch 12/41] x86/mce: Remove duplicated tracing interrupt code Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 18:20 +0200
[patch 21/41] x86/gdt: Use bitfields for initialization Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
[patch 28/41] x86/idt: Move early IDT setup out of 32bit asm Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
[patch 22/41] x86/ldttss: Cleanup 32bit descriptors Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
[patch 20/41] x86: Replace access to desc_struct:a/b fields Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
Re: [patch 20/41] x86: Replace access to desc_struct:a/b fields Juergen Gross <jgross@suse.com> - 2017-08-25 13:20 +0200
Re: [patch 20/41] x86: Replace access to desc_struct:a/b fields Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-08-25 16:00 +0200
Re: [patch 20/41] x86: Replace access to desc_struct:a/b fields Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 16:10 +0200
Re: [patch 20/41] x86: Replace access to desc_struct:a/b fields Steven Rostedt <rostedt@goodmis.org> - 2017-08-25 16:20 +0200
[patch 04/41] x86/boot: Move EISA setup to a proper place Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
Re: [patch 04/41] x86/boot: Move EISA setup to a proper place Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 14:00 +0200
[patch 25/41] x86/idt: Remove unused set_trap_gate() Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
[patch 08/41] x86/apic: Use this_cpu_ptr in local_timer_interrupt Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
[patch 15/41] x86/idt: Remove tracing idt completely Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
Re: [patch 15/41] x86/idt: Remove tracing idt completely Steven Rostedt <rostedt@goodmis.org> - 2017-08-25 23:20 +0200
Re: [patch 15/41] x86/idt: Remove tracing idt completely Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 23:30 +0200
Re: [patch 15/41] x86/idt: Remove tracing idt completely Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 23:30 +0200
csiph-web