Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1720229
| From | Steven Rostedt <rostedt@goodmis.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [patch 12/41] x86/mce: Remove duplicated tracing interrupt code |
| Date | 2017-08-25 18:10 +0200 |
| Message-ID | <uiplg-6dJ-39@gated-at.bofh.it> (permalink) |
| References | <uikvf-2YQ-3@gated-at.bofh.it> <uikEX-3hj-39@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, 25 Aug 2017 12:31:15 +0200
Thomas Gleixner <tglx@linutronix.de> wrote:
> --- a/arch/x86/kernel/cpu/mcheck/mce_amd.c
> +++ b/arch/x86/kernel/cpu/mcheck/mce_amd.c
> @@ -776,24 +776,12 @@ static void __log_error(unsigned int ban
> mce_log(&m);
> }
>
> -static inline void __smp_deferred_error_interrupt(void)
> -{
> - inc_irq_stat(irq_deferred_error_count);
> - deferred_error_int_vector();
> -}
> -
> asmlinkage __visible void __irq_entry smp_deferred_error_interrupt(void)
> {
> entering_irq();
> - __smp_deferred_error_interrupt();
> - exiting_ack_irq();
> -}
> -
> -asmlinkage __visible void __irq_entry smp_trace_deferred_error_interrupt(void)
> -{
> - entering_irq();
> trace_deferred_error_apic_entry(DEFERRED_ERROR_VECTOR);
> - __smp_deferred_error_interrupt();
> + inc_irq_stat(irq_deferred_error_count);
Here we do the inc_irq_stat() after the tracepoint (same as the
original).
> + deferred_error_int_vector();
> trace_deferred_error_apic_exit(DEFERRED_ERROR_VECTOR);
> exiting_ack_irq();
> }
> --- a/arch/x86/kernel/cpu/mcheck/therm_throt.c
> +++ b/arch/x86/kernel/cpu/mcheck/therm_throt.c
> @@ -390,26 +390,12 @@ static void unexpected_thermal_interrupt
>
> static void (*smp_thermal_vector)(void) = unexpected_thermal_interrupt;
>
> -static inline void __smp_thermal_interrupt(void)
> -{
> - inc_irq_stat(irq_thermal_count);
> - smp_thermal_vector();
> -}
> -
> -asmlinkage __visible void __irq_entry
> -smp_thermal_interrupt(struct pt_regs *regs)
> -{
> - entering_irq();
> - __smp_thermal_interrupt();
> - exiting_ack_irq();
> -}
> -
> -asmlinkage __visible void __irq_entry
> -smp_trace_thermal_interrupt(struct pt_regs *regs)
> +asmlinkage __visible void __irq_entry smp_thermal_interrupt(struct pt_regs *r)
> {
> entering_irq();
> + inc_irq_stat(irq_thermal_count);
> trace_thermal_apic_entry(THERMAL_APIC_VECTOR);
Here we do the inc_irq_stat() after the tracepoint (swapped from the
original). Was that intentional?
> - __smp_thermal_interrupt();
> + smp_thermal_vector();
> trace_thermal_apic_exit(THERMAL_APIC_VECTOR);
> exiting_ack_irq();
> }
> --- a/arch/x86/kernel/cpu/mcheck/threshold.c
> +++ b/arch/x86/kernel/cpu/mcheck/threshold.c
> @@ -17,24 +17,12 @@ static void default_threshold_interrupt(
>
> void (*mce_threshold_vector)(void) = default_threshold_interrupt;
>
> -static inline void __smp_threshold_interrupt(void)
> -{
> - inc_irq_stat(irq_threshold_count);
> - mce_threshold_vector();
> -}
> -
> asmlinkage __visible void __irq_entry smp_threshold_interrupt(void)
> {
> entering_irq();
> - __smp_threshold_interrupt();
> - exiting_ack_irq();
> -}
> -
> -asmlinkage __visible void __irq_entry smp_trace_threshold_interrupt(void)
> -{
> - entering_irq();
> trace_threshold_apic_entry(THRESHOLD_APIC_VECTOR);
> - __smp_threshold_interrupt();
> + inc_irq_stat(irq_threshold_count);
Back to inc_irq_stat() after the tracepoint.
-- Steve
> + mce_threshold_vector();
> trace_threshold_apic_exit(THRESHOLD_APIC_VECTOR);
> exiting_ack_irq();
> }
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[patch 00/41] x86: Cleanup IDT code Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
[patch 01/41] x86/irq: Remove vector_used_by_percpu_irq() Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
[patch 26/41] x86/idt: Consolidate IDT invalidation Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
[patch 06/41] x86/traps: Simplify pagefault tracing logic Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
Re: [patch 06/41] x86/traps: Simplify pagefault tracing logic Andy Lutomirski <luto@kernel.org> - 2017-08-25 17:00 +0200
Re: [patch 06/41] x86/traps: Simplify pagefault tracing logic Steven Rostedt <rostedt@goodmis.org> - 2017-08-25 17:20 +0200
Re: [patch 06/41] x86/traps: Simplify pagefault tracing logic Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 17:20 +0200
[patch 07/41] x86/apic: Remove the duplicated tracing version of local_timer_interrupt Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
Re: [patch 07/41] x86/apic: Remove the duplicated tracing version of local_timer_interrupt Steven Rostedt <rostedt@goodmis.org> - 2017-08-25 17:30 +0200
[patch 14/41] x86/smp: Use static key for reschedule interrupt tracing Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
Re: [patch 14/41] x86/smp: Use static key for reschedule interrupt tracing Steven Rostedt <rostedt@goodmis.org> - 2017-08-25 21:50 +0200
Re: [patch 14/41] x86/smp: Use static key for reschedule interrupt tracing Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 22:10 +0200
Re: [patch 14/41] x86/smp: Use static key for reschedule interrupt tracing Steven Rostedt <rostedt@goodmis.org> - 2017-08-25 23:20 +0200
[patch 05/41] x86/tracing: Introduce a static key for exception tracing Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
Re: [patch 05/41] x86/tracing: Introduce a static key for exception tracing Steven Rostedt <rostedt@goodmis.org> - 2017-08-25 17:30 +0200
[patch 10/41] x86/apic: Remove the duplicated tracing versions of interrupts Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
Re: [patch 10/41] x86/apic: Remove the duplicated tracing versions of interrupts Steven Rostedt <rostedt@goodmis.org> - 2017-08-25 17:50 +0200
Re: [patch 10/41] x86/apic: Remove the duplicated tracing versions of interrupts Peter Zijlstra <peterz@infradead.org> - 2017-08-28 10:00 +0200
[patch 11/41] x86/irqwork: Get rid of duplicated tracing interrupt code Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
Re: [patch 11/41] x86/irqwork: Get rid of duplicated tracing interrupt code Steven Rostedt <rostedt@goodmis.org> - 2017-08-25 18:00 +0200
[patch 23/41] x86/idt: Create file for IDT related code Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
[patch 03/41] x86/irq: Move ifdeffery to header file Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
Re: [patch 03/41] x86/irq: Move ifdeffery to header file Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 14:50 +0200
[patch 24/41] x86/idt: Move 32bit idt_descr to C code Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
[patch 16/41] x86/tracing: Disentangle pagefault and resched IPI tracing key Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
[patch 09/41] x86/irq: Get rid of duplicated trace_x86_platform_ipi() code Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
Re: [patch 09/41] x86/irq: Get rid of duplicated trace_x86_platform_ipi() code Steven Rostedt <rostedt@goodmis.org> - 2017-08-25 17:50 +0200
[patch 12/41] x86/mce: Remove duplicated tracing interrupt code Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
Re: [patch 12/41] x86/mce: Remove duplicated tracing interrupt code Steven Rostedt <rostedt@goodmis.org> - 2017-08-25 18:10 +0200
Re: [patch 12/41] x86/mce: Remove duplicated tracing interrupt code Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 18:20 +0200
[patch 21/41] x86/gdt: Use bitfields for initialization Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
[patch 28/41] x86/idt: Move early IDT setup out of 32bit asm Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
[patch 22/41] x86/ldttss: Cleanup 32bit descriptors Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
[patch 20/41] x86: Replace access to desc_struct:a/b fields Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
Re: [patch 20/41] x86: Replace access to desc_struct:a/b fields Juergen Gross <jgross@suse.com> - 2017-08-25 13:20 +0200
Re: [patch 20/41] x86: Replace access to desc_struct:a/b fields Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-08-25 16:00 +0200
Re: [patch 20/41] x86: Replace access to desc_struct:a/b fields Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 16:10 +0200
Re: [patch 20/41] x86: Replace access to desc_struct:a/b fields Steven Rostedt <rostedt@goodmis.org> - 2017-08-25 16:20 +0200
[patch 04/41] x86/boot: Move EISA setup to a proper place Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
Re: [patch 04/41] x86/boot: Move EISA setup to a proper place Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 14:00 +0200
[patch 25/41] x86/idt: Remove unused set_trap_gate() Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
[patch 08/41] x86/apic: Use this_cpu_ptr in local_timer_interrupt Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
[patch 15/41] x86/idt: Remove tracing idt completely Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 13:10 +0200
Re: [patch 15/41] x86/idt: Remove tracing idt completely Steven Rostedt <rostedt@goodmis.org> - 2017-08-25 23:20 +0200
Re: [patch 15/41] x86/idt: Remove tracing idt completely Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 23:30 +0200
Re: [patch 15/41] x86/idt: Remove tracing idt completely Thomas Gleixner <tglx@linutronix.de> - 2017-08-25 23:30 +0200
csiph-web