Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1720110

Re: [PATCH net v2 1/4] net: mvpp2: fix the mac address used when using PPv2.2

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Andrew,

On Fri, Aug 25, 2017 at 04:19:39PM +0200, Andrew Lunn wrote:
> On Fri, Aug 25, 2017 at 04:14:17PM +0200, Antoine Tenart wrote:
> > The mac address is only retrieved from h/w when using PPv2.1. Otherwise
> > the variable holding it is still checked and used if it contains a valid
> > value. As the variable isn't initialized to an invalid mac address
> > value, we end up with random mac addresses which can be the same for all
> > the ports handled by this PPv2 driver.
> > 
> > Fixes this by initializing the h/w mac address variable to {0}, which is
> > an invalid mac address value. This way the random assignation fallback
> > is called and all ports end up with their own addresses.
> > 
> > Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> > Fixes: 2697582144dd ("net: mvpp2: handle misc PPv2.1/PPv2.2 differences")
> 
> Is this patch alone sufficient to fix the problem?

Yes it is.

> Ideally, you want a minimal patch for stable, i.e. -net, and a fuller
> fix can go into net-next.

That was my intention (providing a minimal patch for stable), and I
asked about this approach in the v1. Dave told me to resend the series
to net. Maybe my questions weren't clear enough.

So probably the best way to handle this would have been to send 1/4 to
net and 2-4/4 to net-next (but then there's a dependency between the two
series).

Let's wait for Dave's answer, I'll respin if needed so that it's easy
for him to apply it.

Thanks!
Antoine

-- 
Antoine Ténart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net v2 1/4] net: mvpp2: fix the mac address used when using PPv2.2 Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-25 16:20 +0200
  Re: [PATCH net v2 1/4] net: mvpp2: fix the mac address used when  using PPv2.2 Andrew Lunn <andrew@lunn.ch> - 2017-08-25 16:20 +0200
    Re: [PATCH net v2 1/4] net: mvpp2: fix the mac address used when  using PPv2.2 Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-25 16:30 +0200
      Re: [PATCH net v2 1/4] net: mvpp2: fix the mac address used when  using PPv2.2 Andrew Lunn <andrew@lunn.ch> - 2017-08-25 17:50 +0200
        Re: [PATCH net v2 1/4] net: mvpp2: fix the mac address used when  using PPv2.2 Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-25 18:00 +0200
  Re: [PATCH net v2 1/4] net: mvpp2: fix the mac address used when  using PPv2.2 David Miller <davem@davemloft.net> - 2017-08-28 20:30 +0200

csiph-web