Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1720097

[PATCH net v2 1/4] net: mvpp2: fix the mac address used when using PPv2.2

Show all headers | View raw

The mac address is only retrieved from h/w when using PPv2.1. Otherwise
the variable holding it is still checked and used if it contains a valid
value. As the variable isn't initialized to an invalid mac address
value, we end up with random mac addresses which can be the same for all
the ports handled by this PPv2 driver.

Fixes this by initializing the h/w mac address variable to {0}, which is
an invalid mac address value. This way the random assignation fallback
is called and all ports end up with their own addresses.

Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
Fixes: 2697582144dd ("net: mvpp2: handle misc PPv2.1/PPv2.2 differences")
---
 drivers/net/ethernet/marvell/mvpp2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c
index 48d21c1e09f2..4d598ca8503a 100644
--- a/drivers/net/ethernet/marvell/mvpp2.c
+++ b/drivers/net/ethernet/marvell/mvpp2.c
@@ -6504,7 +6504,7 @@ static int mvpp2_port_probe(struct platform_device *pdev,
 	struct resource *res;
 	const char *dt_mac_addr;
 	const char *mac_from;
-	char hw_mac_addr[ETH_ALEN];
+	char hw_mac_addr[ETH_ALEN] = {0};
 	u32 id;
 	int features;
 	int phy_mode;
-- 
2.13.5

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH net v2 1/4] net: mvpp2: fix the mac address used when using PPv2.2 Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-25 16:20 +0200
  Re: [PATCH net v2 1/4] net: mvpp2: fix the mac address used when  using PPv2.2 Andrew Lunn <andrew@lunn.ch> - 2017-08-25 16:20 +0200
    Re: [PATCH net v2 1/4] net: mvpp2: fix the mac address used when  using PPv2.2 Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-25 16:30 +0200
      Re: [PATCH net v2 1/4] net: mvpp2: fix the mac address used when  using PPv2.2 Andrew Lunn <andrew@lunn.ch> - 2017-08-25 17:50 +0200
        Re: [PATCH net v2 1/4] net: mvpp2: fix the mac address used when  using PPv2.2 Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-25 18:00 +0200
  Re: [PATCH net v2 1/4] net: mvpp2: fix the mac address used when  using PPv2.2 David Miller <davem@davemloft.net> - 2017-08-28 20:30 +0200

csiph-web