Groups > linux.kernel > #1719566

Re: [PATCH] Staging: Android: fix code style in ion_cma_heap.c

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Staging: Android: fix code style in ion_cma_heap.c
Date	2017-08-24 23:00 +0200
Message-ID	<ui7om-2YO-21@gated-at.bofh.it> (permalink)
References	<ui2yl-8q8-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 2017-08-24 at 21:10 +0530, Abishek V Ashok wrote:
> This is a patch to the ion_cma_heap.c file in
> /drivers/staging/andrioid/ion that fixes a blank line and
> kmalloc size warning found by the checkpatch.pl tool.
[]
> diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/ion_cma_heap.c
[]
> @@ -46,7 +45,7 @@ static int ion_cma_allocate(struct ion_heap *heap, struct ion_buffer *buffer,
>  	if (!pages)
>  		return -ENOMEM;
> 
> -	table = kmalloc(sizeof(struct sg_table), GFP_KERNEL);
> +	table = kmalloc(sizeof(struct * table), GFP_KERNEL);

Please make sure you compile the files modified by
your proposed patches before sending the patches.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Staging: Android: fix code style in ion_cma_heap.c Abishek V Ashok <abishekvashok@gmail.com> - 2017-08-24 17:50 +0200
  Re: [PATCH] Staging: Android: fix code style in ion_cma_heap.c Laura Abbott <labbott@redhat.com> - 2017-08-24 18:00 +0200
  Re: [PATCH] Staging: Android: fix code style in ion_cma_heap.c Dan Carpenter <dan.carpenter@oracle.com> - 2017-08-24 21:10 +0200
  Re: [PATCH] Staging: Android: fix code style in ion_cma_heap.c Joe Perches <joe@perches.com> - 2017-08-24 23:00 +0200

csiph-web