Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1719356

Re: [PATCH] Staging: Android: fix code style in ion_cma_heap.c

Show all headers | View raw

On 08/24/2017 08:40 AM, Abishek V Ashok wrote:
> This is a patch to the ion_cma_heap.c file in
> /drivers/staging/andrioid/ion that fixes a blank line and
> kmalloc size warning found by the checkpatch.pl tool.
> 

You've done two things in this patch, please stick to a single
change per patch.

> Signed-off-by: Abhishek V Ashok <abishekvashok@gmail.com>
> ---
>  drivers/staging/android/ion/ion_cma_heap.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/ion_cma_heap.c
> index a0949bc0..1589b9e0 100644
> --- a/drivers/staging/android/ion/ion_cma_heap.c
> +++ b/drivers/staging/android/ion/ion_cma_heap.c
> @@ -31,7 +31,6 @@ struct ion_cma_heap {
> 
>  #define to_cma_heap(x) container_of(x, struct ion_cma_heap, heap)
> 
> -
>  /* ION CMA heap operations functions */
>  static int ion_cma_allocate(struct ion_heap *heap, struct ion_buffer *buffer,
>  			    unsigned long len,
> @@ -46,7 +45,7 @@ static int ion_cma_allocate(struct ion_heap *heap, struct ion_buffer *buffer,
>  	if (!pages)
>  		return -ENOMEM;
> 
> -	table = kmalloc(sizeof(struct sg_table), GFP_KERNEL);
> +	table = kmalloc(sizeof(struct * table), GFP_KERNEL);
>  	if (!table)
>  		goto err;
> 
> --
> 2.11.0
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] Staging: Android: fix code style in ion_cma_heap.c Abishek V Ashok <abishekvashok@gmail.com> - 2017-08-24 17:50 +0200
  Re: [PATCH] Staging: Android: fix code style in ion_cma_heap.c Laura Abbott <labbott@redhat.com> - 2017-08-24 18:00 +0200
  Re: [PATCH] Staging: Android: fix code style in ion_cma_heap.c Dan Carpenter <dan.carpenter@oracle.com> - 2017-08-24 21:10 +0200
  Re: [PATCH] Staging: Android: fix code style in ion_cma_heap.c Joe Perches <joe@perches.com> - 2017-08-24 23:00 +0200

csiph-web