Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1719517

Re: [PATCH 1/2] ext4: Delete an error message for a failed memory allocation in ext4_multi_mount_protect()

Show all headers | View raw

On Sat, Aug 19, 2017 at 12:08:29PM -0500, Eric Sandeen wrote:
> On 8/19/17 6:47 AM, SF Markus Elfring wrote:
> > From: Markus Elfring <elfring@users.sourceforge.net>
> > Date: Sat, 19 Aug 2017 13:04:50 +0200
> > 
> > Omit an extra message for a memory allocation failure in this function.
> 
> I might be dense, but what makes this message "extra?"
> 
> (I suppose kmalloc squawks too if it fails, but is Coccinelle
> now warning about explicit memory allocation failure warnings?)
> 

Yeah...  Checkpatch complains that the kmalloc squawks is enough.
"WARNING: Possible unnecessary 'out of memory' message".  This
allocation is small so it's guaranteed to succeed in current kernels.

regards,
dan carpenter

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] ext4: Delete an error message for a failed memory  allocation in ext4_multi_mount_protect() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-19 13:50 +0200
  Re: [PATCH 1/2] ext4: Delete an error message for a failed memory  allocation in ext4_multi_mount_protect() Eric Sandeen <esandeen@redhat.com> - 2017-08-19 19:10 +0200
    Re: ext4: Delete an error message for a failed memory allocation in  ext4_multi_mount_protect() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-19 20:10 +0200
      Re: ext4: Delete an error message for a failed memory allocation in  ext4_multi_mount_protect() Theodore Ts'o <tytso@mit.edu> - 2017-08-24 19:50 +0200
    Re: [PATCH 1/2] ext4: Delete an error message for a failed memory  allocation in ext4_multi_mount_protect() Dan Carpenter <dan.carpenter@oracle.com> - 2017-08-24 21:20 +0200

csiph-web