Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1719472

Re: ext4: Delete an error message for a failed memory allocation in ext4_multi_mount_protect()

From Theodore Ts'o <tytso@mit.edu>
Newsgroups linux.kernel
Subject Re: ext4: Delete an error message for a failed memory allocation in ext4_multi_mount_protect()
Date 2017-08-24 19:50 +0200
Message-ID <ui4qu-1bx-7@gated-at.bofh.it> (permalink)
References <ugaql-NZ-3@gated-at.bofh.it> <ugaql-NZ-5@gated-at.bofh.it> <ugfq2-42G-11@gated-at.bofh.it> <uggm6-4B1-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sat, Aug 19, 2017 at 08:00:31PM +0200, SF Markus Elfring wrote:
> >> Omit an extra message for a memory allocation failure in this function.
> > 
> > I might be dense, but what makes this message "extra?"
> > 
> > (I suppose kmalloc squawks too if it fails,
> 
> Do you find the default allocation failure report sufficient?

From a helpdesk reporting situation, having a more specific message
when there is a MMP failure causing the mount to fail is definitely
useful.

So, NACK.

					- Ted

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/2] ext4: Delete an error message for a failed memory  allocation in ext4_multi_mount_protect() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-19 13:50 +0200
  Re: [PATCH 1/2] ext4: Delete an error message for a failed memory  allocation in ext4_multi_mount_protect() Eric Sandeen <esandeen@redhat.com> - 2017-08-19 19:10 +0200
    Re: ext4: Delete an error message for a failed memory allocation in  ext4_multi_mount_protect() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-08-19 20:10 +0200
      Re: ext4: Delete an error message for a failed memory allocation in  ext4_multi_mount_protect() Theodore Ts'o <tytso@mit.edu> - 2017-08-24 19:50 +0200
    Re: [PATCH 1/2] ext4: Delete an error message for a failed memory  allocation in ext4_multi_mount_protect() Dan Carpenter <dan.carpenter@oracle.com> - 2017-08-24 21:20 +0200

csiph-web