Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1719451

Re: [EXT] Re: [PATCH net-next 09/13] net: mvpp2: dynamic reconfiguration of the PHY mode

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, Aug 24, 2017 at 05:08:29PM +0000, Stefan Chulski wrote:
> > > Imagine phylib is using the copper Ethernet PHY, but the MAC is using
> > > the SFP port. Somebody pulls out the copper cable, phylib says the
> > > link is down, turns the carrier off and calls the callback. Not good,
> > > since your SFP cable is still plugged in...  Ethtool is
> > > returning/setting stuff in the Copper Ethernet PHY, when in fact you
> > > intend to be setting SFP settings.
> > 
> > I see what could be the issue but I do not understand one aspect though:
> > how could we switch from one PHY to another, as there's only one output
> > between the SoC (and so a given GoP#) and the board. So if a given PHY can
> > handle multiple modes I see, but in the other case a muxing somewhere would
> > be needed? Or did I miss something?
> 
> I think PHY name and PHY mode struct that describe here both MAC to
> PHY and PHY to PHY connection create confusion...  Serdes IP lane
> doesn't care if connector is SFP, RJ45 or direct attached cable.
> mvpp22_comphy_init only configures MAC to PHY
> connection. SFI for 10G(KR in mainline), SGMII for 1G and HS_SGMII for
> 2.5G.

So maybe one confusion was to name them PHY_MODE_10GKR and
PHY_MODE_SGMII. It could be PHY_MODE_10G and PHY_MODE_1G instead.

Does that sound right?

Antoine

-- 
Antoine Ténart, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next 00/13] net: mvpp2: comphy configuration Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 10:40 +0200
  [PATCH net-next 05/13] net: mvpp2: do not force the link mode Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 10:40 +0200
  [PATCH net-next 02/13] phy: add the mvebu cp110 comphy driver Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 10:40 +0200
    Re: [PATCH net-next 02/13] phy: add the mvebu cp110 comphy driver Andrew Lunn <andrew@lunn.ch> - 2017-08-24 15:40 +0200
      Re: [PATCH net-next 02/13] phy: add the mvebu cp110 comphy driver Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 15:50 +0200
        Re: [PATCH net-next 02/13] phy: add the mvebu cp110 comphy driver Andrew Lunn <andrew@lunn.ch> - 2017-08-24 16:00 +0200
          RE: [PATCH net-next 02/13] phy: add the mvebu cp110 comphy driver Stefan Chulski <stefanc@marvell.com> - 2017-08-24 16:00 +0200
            Re: [PATCH net-next 02/13] phy: add the mvebu cp110 comphy driver Andrew Lunn <andrew@lunn.ch> - 2017-08-24 16:10 +0200
            Re: [PATCH net-next 02/13] phy: add the mvebu cp110 comphy driver Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 16:10 +0200
    Re: [PATCH net-next 02/13] phy: add the mvebu cp110 comphy driver Andrew Lunn <andrew@lunn.ch> - 2017-08-24 15:50 +0200
      Re: [PATCH net-next 02/13] phy: add the mvebu cp110 comphy driver Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 16:00 +0200
  [PATCH net-next 04/13] net: mvpp2: initialize the comphy Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 10:50 +0200
  [PATCH net-next 13/13] arm64: defconfig: enable Marvell CP110 comphy Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 10:50 +0200
  [PATCH net-next 06/13] net: mvpp2: simplify the link_event function Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 10:50 +0200
  [PATCH net-next 01/13] phy: add sgmii and 10gkr modes to the phy_mode enum Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 10:50 +0200
    Re: [PATCH net-next 01/13] phy: add sgmii and 10gkr modes to the  phy_mode enum Andrew Lunn <andrew@lunn.ch> - 2017-08-24 15:30 +0200
      Re: [PATCH net-next 01/13] phy: add sgmii and 10gkr modes to the  phy_mode enum Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 15:40 +0200
  [PATCH net-next 03/13] Documentation/bindings: phy: document the Marvell comphy driver Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 10:50 +0200
  [PATCH net-next 09/13] net: mvpp2: dynamic reconfiguration of the PHY mode Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 10:50 +0200
    Re: [PATCH net-next 09/13] net: mvpp2: dynamic reconfiguration of  the PHY mode Andrew Lunn <andrew@lunn.ch> - 2017-08-24 17:00 +0200
      Re: [PATCH net-next 09/13] net: mvpp2: dynamic reconfiguration of  the PHY mode Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 18:00 +0200
        Re: [PATCH net-next 09/13] net: mvpp2: dynamic reconfiguration of  the PHY mode Andrew Lunn <andrew@lunn.ch> - 2017-08-24 18:10 +0200
          Re: [PATCH net-next 09/13] net: mvpp2: dynamic reconfiguration of  the PHY mode Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 18:20 +0200
            Re: [PATCH net-next 09/13] net: mvpp2: dynamic reconfiguration of  the PHY mode Andrew Lunn <andrew@lunn.ch> - 2017-08-24 19:00 +0200
              Re: [PATCH net-next 09/13] net: mvpp2: dynamic reconfiguration of  the PHY mode Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-08-24 19:10 +0200
                Re: [PATCH net-next 09/13] net: mvpp2: dynamic reconfiguration of  the PHY mode Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 19:20 +0200
                RE: [EXT] Re: [PATCH net-next 09/13] net: mvpp2: dynamic  reconfiguration of the PHY mode Stefan Chulski <stefanc@marvell.com> - 2017-08-24 19:30 +0200
            RE: [EXT] Re: [PATCH net-next 09/13] net: mvpp2: dynamic  reconfiguration of the PHY mode Stefan Chulski <stefanc@marvell.com> - 2017-08-24 19:10 +0200
              Re: [EXT] Re: [PATCH net-next 09/13] net: mvpp2: dynamic  reconfiguration of the PHY mode Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 19:20 +0200
                RE: [EXT] Re: [PATCH net-next 09/13] net: mvpp2: dynamic  reconfiguration of the PHY mode Stefan Chulski <stefanc@marvell.com> - 2017-08-24 19:20 +0200
                Re: [EXT] Re: [PATCH net-next 09/13] net: mvpp2: dynamic  reconfiguration of the PHY mode Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-08-25 10:30 +0200
      Re: [PATCH net-next 09/13] net: mvpp2: dynamic reconfiguration of  the PHY mode Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-08-24 19:10 +0200
        Re: [PATCH net-next 09/13] net: mvpp2: dynamic reconfiguration of  the PHY mode Andrew Lunn <andrew@lunn.ch> - 2017-08-24 19:50 +0200
          Re: [PATCH net-next 09/13] net: mvpp2: dynamic reconfiguration of  the PHY mode Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-08-25 00:20 +0200
  [PATCH net-next 12/13] arm64: dts: marvell: mcbin: add comphy references to Ethernet ports Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 10:50 +0200
    Re: [PATCH net-next 12/13] arm64: dts: marvell: mcbin: add comphy  references to Ethernet ports Andrew Lunn <andrew@lunn.ch> - 2017-08-24 16:00 +0200
      Re: [PATCH net-next 12/13] arm64: dts: marvell: mcbin: add comphy  references to Ethernet ports Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 16:10 +0200
  [PATCH net-next 08/13] net: mvpp2: check the netif is running in the link_event function Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 10:50 +0200
  [PATCH net-next 07/13] net: mvpp2: improve the link management function Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 10:50 +0200
    Re: [PATCH net-next 07/13] net: mvpp2: improve the link management  function Andrew Lunn <andrew@lunn.ch> - 2017-08-24 16:10 +0200
      Re: [PATCH net-next 07/13] net: mvpp2: improve the link management  function Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 16:20 +0200

csiph-web