Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1719448

Re: [PATCH net-next 09/13] net: mvpp2: dynamic reconfiguration of the PHY mode

Show all headers | View raw

On Thu, Aug 24, 2017 at 04:56:09PM +0200, Andrew Lunn wrote:
> On Thu, Aug 24, 2017 at 10:38:19AM +0200, Antoine Tenart wrote:
> > This patch adds logic to reconfigure the comphy/gop when the link status
> > change at runtime. This is very useful on boards such as the mcbin which
> > have SFP and Ethernet ports connected to the same MAC port: depending on
> > what the user connects the driver will automatically reconfigure the
> > link mode.
> 
> Hi Antoine
> 
> I would expect each of these external Ethernet ports to have its own
> Ethernet PHY. Don't you need to disconnect from one Ethernet phy and
> connect to the other Ethernet PHY when you change external Ethernet
> port?

I think you're all getting confused.  The link mode has very little to
do with whether you're using SFP+ or whether you're using the RJ45 at
10G speeds.  The link mode has everything to do with the speed at which
the link is negotiated at.

So please, put SFP+ out of your minds for this - SFP+ isn't the reason
why you need to switch the MAC link mode.

In all cases, the mvpp2 to 88x3310 link ends up in one of two modes:
1. SGMII for RJ45 speeds less than 10G.  Autonegotiation on SGMII
    at the mvpp2 end *must* be enabled for the PHY to work.

2. 10Gbase-R for 10G speeds, whether that be for SFP+ or RJ45 at 10G.
   Note: mcbin does not support SFP (1G) modules on the SFP+ ports.

The 88x3310 driver in the kernel knows about these combinations and
sets the phy interface parameter correctly depending on whether the
PHY has configured itself for copper at whatever speed or SFP+.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next 00/13] net: mvpp2: comphy configuration Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 10:40 +0200
  [PATCH net-next 05/13] net: mvpp2: do not force the link mode Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 10:40 +0200
  [PATCH net-next 02/13] phy: add the mvebu cp110 comphy driver Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 10:40 +0200
    Re: [PATCH net-next 02/13] phy: add the mvebu cp110 comphy driver Andrew Lunn <andrew@lunn.ch> - 2017-08-24 15:40 +0200
      Re: [PATCH net-next 02/13] phy: add the mvebu cp110 comphy driver Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 15:50 +0200
        Re: [PATCH net-next 02/13] phy: add the mvebu cp110 comphy driver Andrew Lunn <andrew@lunn.ch> - 2017-08-24 16:00 +0200
          RE: [PATCH net-next 02/13] phy: add the mvebu cp110 comphy driver Stefan Chulski <stefanc@marvell.com> - 2017-08-24 16:00 +0200
            Re: [PATCH net-next 02/13] phy: add the mvebu cp110 comphy driver Andrew Lunn <andrew@lunn.ch> - 2017-08-24 16:10 +0200
            Re: [PATCH net-next 02/13] phy: add the mvebu cp110 comphy driver Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 16:10 +0200
    Re: [PATCH net-next 02/13] phy: add the mvebu cp110 comphy driver Andrew Lunn <andrew@lunn.ch> - 2017-08-24 15:50 +0200
      Re: [PATCH net-next 02/13] phy: add the mvebu cp110 comphy driver Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 16:00 +0200
  [PATCH net-next 04/13] net: mvpp2: initialize the comphy Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 10:50 +0200
  [PATCH net-next 13/13] arm64: defconfig: enable Marvell CP110 comphy Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 10:50 +0200
  [PATCH net-next 06/13] net: mvpp2: simplify the link_event function Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 10:50 +0200
  [PATCH net-next 01/13] phy: add sgmii and 10gkr modes to the phy_mode enum Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 10:50 +0200
    Re: [PATCH net-next 01/13] phy: add sgmii and 10gkr modes to the  phy_mode enum Andrew Lunn <andrew@lunn.ch> - 2017-08-24 15:30 +0200
      Re: [PATCH net-next 01/13] phy: add sgmii and 10gkr modes to the  phy_mode enum Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 15:40 +0200
  [PATCH net-next 03/13] Documentation/bindings: phy: document the Marvell comphy driver Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 10:50 +0200
  [PATCH net-next 09/13] net: mvpp2: dynamic reconfiguration of the PHY mode Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 10:50 +0200
    Re: [PATCH net-next 09/13] net: mvpp2: dynamic reconfiguration of  the PHY mode Andrew Lunn <andrew@lunn.ch> - 2017-08-24 17:00 +0200
      Re: [PATCH net-next 09/13] net: mvpp2: dynamic reconfiguration of  the PHY mode Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 18:00 +0200
        Re: [PATCH net-next 09/13] net: mvpp2: dynamic reconfiguration of  the PHY mode Andrew Lunn <andrew@lunn.ch> - 2017-08-24 18:10 +0200
          Re: [PATCH net-next 09/13] net: mvpp2: dynamic reconfiguration of  the PHY mode Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 18:20 +0200
            Re: [PATCH net-next 09/13] net: mvpp2: dynamic reconfiguration of  the PHY mode Andrew Lunn <andrew@lunn.ch> - 2017-08-24 19:00 +0200
              Re: [PATCH net-next 09/13] net: mvpp2: dynamic reconfiguration of  the PHY mode Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-08-24 19:10 +0200
                Re: [PATCH net-next 09/13] net: mvpp2: dynamic reconfiguration of  the PHY mode Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 19:20 +0200
                RE: [EXT] Re: [PATCH net-next 09/13] net: mvpp2: dynamic  reconfiguration of the PHY mode Stefan Chulski <stefanc@marvell.com> - 2017-08-24 19:30 +0200
            RE: [EXT] Re: [PATCH net-next 09/13] net: mvpp2: dynamic  reconfiguration of the PHY mode Stefan Chulski <stefanc@marvell.com> - 2017-08-24 19:10 +0200
              Re: [EXT] Re: [PATCH net-next 09/13] net: mvpp2: dynamic  reconfiguration of the PHY mode Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 19:20 +0200
                RE: [EXT] Re: [PATCH net-next 09/13] net: mvpp2: dynamic  reconfiguration of the PHY mode Stefan Chulski <stefanc@marvell.com> - 2017-08-24 19:20 +0200
                Re: [EXT] Re: [PATCH net-next 09/13] net: mvpp2: dynamic  reconfiguration of the PHY mode Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-08-25 10:30 +0200
      Re: [PATCH net-next 09/13] net: mvpp2: dynamic reconfiguration of  the PHY mode Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-08-24 19:10 +0200
        Re: [PATCH net-next 09/13] net: mvpp2: dynamic reconfiguration of  the PHY mode Andrew Lunn <andrew@lunn.ch> - 2017-08-24 19:50 +0200
          Re: [PATCH net-next 09/13] net: mvpp2: dynamic reconfiguration of  the PHY mode Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-08-25 00:20 +0200
  [PATCH net-next 12/13] arm64: dts: marvell: mcbin: add comphy references to Ethernet ports Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 10:50 +0200
    Re: [PATCH net-next 12/13] arm64: dts: marvell: mcbin: add comphy  references to Ethernet ports Andrew Lunn <andrew@lunn.ch> - 2017-08-24 16:00 +0200
      Re: [PATCH net-next 12/13] arm64: dts: marvell: mcbin: add comphy  references to Ethernet ports Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 16:10 +0200
  [PATCH net-next 08/13] net: mvpp2: check the netif is running in the link_event function Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 10:50 +0200
  [PATCH net-next 07/13] net: mvpp2: improve the link management function Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 10:50 +0200
    Re: [PATCH net-next 07/13] net: mvpp2: improve the link management  function Andrew Lunn <andrew@lunn.ch> - 2017-08-24 16:10 +0200
      Re: [PATCH net-next 07/13] net: mvpp2: improve the link management  function Antoine Tenart <antoine.tenart@free-electrons.com> - 2017-08-24 16:20 +0200

csiph-web