Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1719233

Re: [PATCH nf-next] netfilter: xt_CHECKSUM: avoid bad offload warnings on GSO packets

From Florian Westphal <fw@strlen.de>
Newsgroups linux.kernel
Subject Re: [PATCH nf-next] netfilter: xt_CHECKSUM: avoid bad offload warnings on GSO packets
Date 2017-08-24 15:30 +0200
Message-ID <ui0mS-78Q-13@gated-at.bofh.it> (permalink)
References <uhXS2-5i7-7@gated-at.bofh.it> <uhY1H-5ln-1@gated-at.bofh.it> <uhYbn-5DS-11@gated-at.bofh.it> <ui03w-70q-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Davide Caratti <dcaratti@redhat.com> wrote:
> Small nit: may I suggest you to call skb_csum_hwoffload_help() instead of
> skb_checksum_help(), so that we avoid corrupting SCTP packets in case they
> hit xt_CHECKSUM target?

Alternatively we could restrict the target to udp only.

AFAIU the only reason this thing exists is to fix up udp checksum
for old dhcp clients that use AF_PACKET without evaluating the extra
metadata that indicates when a 'bad' checksum is in fact ok because it
is supposed to be filled in by hardware later.

This can happen in virtual environemnt when such skb is directly passed
to vm.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH nf-next] netfilter: xt_CHECKSUM: avoid bad offload warnings on  GSO packets Michal Kubecek <mkubecek@suse.cz> - 2017-08-24 12:50 +0200
  Re: [PATCH nf-next] netfilter: xt_CHECKSUM: avoid bad offload  warnings on GSO packets Florian Westphal <fw@strlen.de> - 2017-08-24 13:00 +0200
    Re: [PATCH nf-next] netfilter: xt_CHECKSUM: avoid bad offload  warnings on GSO packets Michal Kubecek <mkubecek@suse.cz> - 2017-08-24 13:10 +0200
      Re: [PATCH nf-next] netfilter: xt_CHECKSUM: avoid bad offload  warnings on GSO packets Davide Caratti <dcaratti@redhat.com> - 2017-08-24 15:10 +0200
        Re: [PATCH nf-next] netfilter: xt_CHECKSUM: avoid bad offload  warnings on GSO packets Florian Westphal <fw@strlen.de> - 2017-08-24 15:30 +0200
          Re: [PATCH nf-next] netfilter: xt_CHECKSUM: avoid bad offload  warnings on GSO packets Michal Kubecek <mkubecek@suse.cz> - 2017-08-25 11:30 +0200
            Re: [PATCH nf-next] netfilter: xt_CHECKSUM: avoid bad offload  warnings on GSO packets Florian Westphal <fw@strlen.de> - 2017-08-25 11:50 +0200
            Re: [PATCH nf-next] netfilter: xt_CHECKSUM: avoid bad offload  warnings on GSO packets Florian Westphal <fw@strlen.de> - 2017-08-25 11:50 +0200
        Re: [PATCH nf-next] netfilter: xt_CHECKSUM: avoid bad offload  warnings on GSO packets Michal Kubecek <mkubecek@suse.cz> - 2017-08-25 11:30 +0200

csiph-web