Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1719215

Re: [PATCH nf-next] netfilter: xt_CHECKSUM: avoid bad offload warnings on GSO packets

Show all headers | View raw

On Thu, 2017-08-24 at 13:07 +0200, Michal Kubecek wrote:
> On Thu, Aug 24, 2017 at 12:51:18PM +0200, Florian Westphal wrote:
> > Michal Kubecek <mkubecek@suse.cz> wrote:
> > > When --checksum_fill action is applied to a GSO packet, checksum_tg() calls
> > > skb_checksum_help() which is only meant to be applied to non-GSO packets so
> > > that it issues a warning.
> > > 
> > > This can be easily triggered by using e.g.
> > > 
> > >   iptables -t mangle -A OUTPUT -j CHECKSUM --checksum-fill
> > > 
> > > and sending TCP stream via a device with GSO enabled.
> > > 
> > > While this can be considered a misconfiguration, I believe the bad offload
> > > warning is supposed to catch bugs in drivers and networking stack, not
> > > misconfigured firewalls. So let's ignore such packets and only issue a one
> > > time warning with pr_warn_once() rather than a WARN with stack trace and
> > > tainted kernel.
> > 
> > Why issue a warning at all?
> > What kind of action should be taken upon seeing such warning?
> 
> Check and fix the configuration. The reason why I left at least some
> kind of warning is that the module does something that is unexpected as
> the checksum is not calculated (this module is often used in
> virtualization environments where "hardware checksum offload" in fact
> means the checksum is not computed at all).
> 

hello Michal,

GSO should be capable of computing the checksum on individual segments
later, so I also think the warning can be removed.

Small nit: may I suggest you to call skb_csum_hwoffload_help() instead of
skb_checksum_help(), so that we avoid corrupting SCTP packets in case they
hit xt_CHECKSUM target?

thank you in advance,
regards
-- 
davide

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH nf-next] netfilter: xt_CHECKSUM: avoid bad offload warnings on  GSO packets Michal Kubecek <mkubecek@suse.cz> - 2017-08-24 12:50 +0200
  Re: [PATCH nf-next] netfilter: xt_CHECKSUM: avoid bad offload  warnings on GSO packets Florian Westphal <fw@strlen.de> - 2017-08-24 13:00 +0200
    Re: [PATCH nf-next] netfilter: xt_CHECKSUM: avoid bad offload  warnings on GSO packets Michal Kubecek <mkubecek@suse.cz> - 2017-08-24 13:10 +0200
      Re: [PATCH nf-next] netfilter: xt_CHECKSUM: avoid bad offload  warnings on GSO packets Davide Caratti <dcaratti@redhat.com> - 2017-08-24 15:10 +0200
        Re: [PATCH nf-next] netfilter: xt_CHECKSUM: avoid bad offload  warnings on GSO packets Florian Westphal <fw@strlen.de> - 2017-08-24 15:30 +0200
          Re: [PATCH nf-next] netfilter: xt_CHECKSUM: avoid bad offload  warnings on GSO packets Michal Kubecek <mkubecek@suse.cz> - 2017-08-25 11:30 +0200
            Re: [PATCH nf-next] netfilter: xt_CHECKSUM: avoid bad offload  warnings on GSO packets Florian Westphal <fw@strlen.de> - 2017-08-25 11:50 +0200
            Re: [PATCH nf-next] netfilter: xt_CHECKSUM: avoid bad offload  warnings on GSO packets Florian Westphal <fw@strlen.de> - 2017-08-25 11:50 +0200
        Re: [PATCH nf-next] netfilter: xt_CHECKSUM: avoid bad offload  warnings on GSO packets Michal Kubecek <mkubecek@suse.cz> - 2017-08-25 11:30 +0200

csiph-web