Groups > linux.kernel > #1719252

Re: [PATCH 1/2] nfit: Use init_completion() in acpi_nfit_flush_probe()

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] nfit: Use init_completion() in acpi_nfit_flush_probe()
Date	2017-08-24 15:50 +0200
Message-ID	<ui0Ge-7fv-23@gated-at.bofh.it> (permalink)
References	<uhFLs-2fj-11@gated-at.bofh.it> <uhFLs-2fj-9@gated-at.bofh.it> <ui03x-70q-25@gated-at.bofh.it> <ui0mS-78Q-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Aug 24, 2017 at 3:28 PM, Boqun Feng <boqun.feng@gmail.com> wrote:
> On Thu, Aug 24, 2017 at 03:07:42PM +0200, Thomas Gleixner wrote:
>> On Wed, 23 Aug 2017, Boqun Feng wrote:
>>
>> > There is no need to use COMPLETION_INITIALIZER_ONSTACK() in
>> > acpi_nfit_flush_probe(), replace it with init_completion().
>>
>> You completely fail to explain WHY.
>>
>
> I thought COMPLETION_INITIALIZER_ONSTACK() should only use in assigment
> or compound literals, so the usage here is obviously wrong, but seems
> I was wrong?
>
> Ingo,
>
> Is the usage of COMPLETION_INITIALIZER_ONSTACK() correct? If not,
> I could rephrase my commit log saying this is a fix for wrong usage of
> COMPLETION_INITIALIZER_ONSTACK(), otherwise, I will rewrite the commit
> indicating this patch is a necessary dependency for patch #2. Thanks!

I think your patch is correct, but your changelog text is useless, as
Thomas mentioned: you should instead explain that it breaks with the
other fix in the series, and what the difference between init_completion()
and COMPLETION_INITIALIZER_ONSTACK() is.

      Arnd

Thread

[PATCH 1/2] nfit: Use init_completion() in acpi_nfit_flush_probe() Boqun Feng <boqun.feng@gmail.com> - 2017-08-23 17:30 +0200
  Re: [PATCH 1/2] nfit: Use init_completion() in acpi_nfit_flush_probe() Dan Williams <dan.j.williams@intel.com> - 2017-08-24 00:10 +0200
  Re: [PATCH 1/2] nfit: Use init_completion() in  acpi_nfit_flush_probe() Thomas Gleixner <tglx@linutronix.de> - 2017-08-24 15:10 +0200
    Re: [PATCH 1/2] nfit: Use init_completion() in  acpi_nfit_flush_probe() Boqun Feng <boqun.feng@gmail.com> - 2017-08-24 15:30 +0200
      Re: [PATCH 1/2] nfit: Use init_completion() in acpi_nfit_flush_probe() Arnd Bergmann <arnd@arndb.de> - 2017-08-24 15:50 +0200
  [PATCH v2 1/2] nfit: Fix the abuse of COMPLETION_INITIALIZER_ONSTACK() Boqun Feng <boqun.feng@gmail.com> - 2017-08-24 16:30 +0200
    Re: [PATCH v2 1/2] nfit: Fix the abuse of  COMPLETION_INITIALIZER_ONSTACK() Boqun Feng <boqun.feng@gmail.com> - 2017-08-25 02:20 +0200
    Re: [PATCH v2 1/2] nfit: Fix the abuse of COMPLETION_INITIALIZER_ONSTACK() Dan Williams <dan.j.williams@intel.com> - 2017-08-25 02:40 +0200

csiph-web