Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1719223
| From | Thomas Gleixner <tglx@linutronix.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/2] nfit: Use init_completion() in acpi_nfit_flush_probe() |
| Date | 2017-08-24 15:10 +0200 |
| Message-ID | <ui03x-70q-25@gated-at.bofh.it> (permalink) |
| References | <uhFLs-2fj-11@gated-at.bofh.it> <uhFLs-2fj-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, 23 Aug 2017, Boqun Feng wrote: > There is no need to use COMPLETION_INITIALIZER_ONSTACK() in > acpi_nfit_flush_probe(), replace it with init_completion(). You completely fail to explain WHY. Thanks, tglx > Signed-off-by: Boqun Feng <boqun.feng@gmail.com> > --- > drivers/acpi/nfit/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c > index 19182d091587..1893e416e7c0 100644 > --- a/drivers/acpi/nfit/core.c > +++ b/drivers/acpi/nfit/core.c > @@ -2884,7 +2884,7 @@ static int acpi_nfit_flush_probe(struct nvdimm_bus_descriptor *nd_desc) > * need to be interruptible while waiting. > */ > INIT_WORK_ONSTACK(&flush.work, flush_probe); > - COMPLETION_INITIALIZER_ONSTACK(flush.cmp); > + init_completion(&flush.cmp); > queue_work(nfit_wq, &flush.work); > mutex_unlock(&acpi_desc->init_mutex); > > -- > 2.14.1 > >
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/2] nfit: Use init_completion() in acpi_nfit_flush_probe() Boqun Feng <boqun.feng@gmail.com> - 2017-08-23 17:30 +0200
Re: [PATCH 1/2] nfit: Use init_completion() in acpi_nfit_flush_probe() Dan Williams <dan.j.williams@intel.com> - 2017-08-24 00:10 +0200
Re: [PATCH 1/2] nfit: Use init_completion() in acpi_nfit_flush_probe() Thomas Gleixner <tglx@linutronix.de> - 2017-08-24 15:10 +0200
Re: [PATCH 1/2] nfit: Use init_completion() in acpi_nfit_flush_probe() Boqun Feng <boqun.feng@gmail.com> - 2017-08-24 15:30 +0200
Re: [PATCH 1/2] nfit: Use init_completion() in acpi_nfit_flush_probe() Arnd Bergmann <arnd@arndb.de> - 2017-08-24 15:50 +0200
[PATCH v2 1/2] nfit: Fix the abuse of COMPLETION_INITIALIZER_ONSTACK() Boqun Feng <boqun.feng@gmail.com> - 2017-08-24 16:30 +0200
Re: [PATCH v2 1/2] nfit: Fix the abuse of COMPLETION_INITIALIZER_ONSTACK() Boqun Feng <boqun.feng@gmail.com> - 2017-08-25 02:20 +0200
Re: [PATCH v2 1/2] nfit: Fix the abuse of COMPLETION_INITIALIZER_ONSTACK() Dan Williams <dan.j.williams@intel.com> - 2017-08-25 02:40 +0200
csiph-web