RE: [PATCH v2 1/6] fsl/fman: enable FMan Keygen

From	Madalin-cristian Bucur <madalin.bucur@nxp.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH v2 1/6] fsl/fman: enable FMan Keygen
Date	2017-08-23 07:20 +0200
Message-ID	<uhwf7-4Nc-5@gated-at.bofh.it> (permalink)
References	<uhp3X-86X-17@gated-at.bofh.it> <uhp3X-86X-13@gated-at.bofh.it> <uhvCq-4iI-9@gated-at.bofh.it> <uhvM5-4lW-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> -----Original Message-----
> From: David Miller [mailto:davem@davemloft.net]
> Sent: Wednesday, August 23, 2017 7:47 AM
> To: Madalin-cristian Bucur <madalin.bucur@nxp.com>
> Cc: netdev@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH v2 1/6] fsl/fman: enable FMan Keygen
> 
> From: Madalin-cristian Bucur <madalin.bucur@nxp.com>
> Date: Wed, 23 Aug 2017 04:36:56 +0000
> 
> > The struct fman is only visible in the fman file, the fman port
> > module uses struct fman as an opaque pointer, thus this export.
> 
> Don't use that programming model.
> 
> Export the datastructure properly to it's users.
> 
> This abstraction scheme is so wasteful and costly.

Normally does not come with this cost, it's this case where one of the
sub-modules needs to call into another that gets things complicated.
I'll move struct fman to the header file.

Thanks,
Madalin

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 1/6] fsl/fman: enable FMan Keygen David Miller <davem@davemloft.net> - 2017-08-22 23:40 +0200
  RE: [PATCH v2 1/6] fsl/fman: enable FMan Keygen Madalin-cristian Bucur <madalin.bucur@nxp.com> - 2017-08-23 06:40 +0200
    Re: [PATCH v2 1/6] fsl/fman: enable FMan Keygen David Miller <davem@davemloft.net> - 2017-08-23 06:50 +0200
      RE: [PATCH v2 1/6] fsl/fman: enable FMan Keygen Madalin-cristian Bucur <madalin.bucur@nxp.com> - 2017-08-23 07:20 +0200

csiph-web