Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1718026
| From | Madalin-cristian Bucur <madalin.bucur@nxp.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | RE: [PATCH v2 1/6] fsl/fman: enable FMan Keygen |
| Date | 2017-08-23 06:40 +0200 |
| Message-ID | <uhvCq-4iI-9@gated-at.bofh.it> (permalink) |
| References | <uhp3X-86X-15@gated-at.bofh.it> <uhp3X-86X-17@gated-at.bofh.it> <uhp3X-86X-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
> -----Original Message-----
> From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org]
> On Behalf Of David Miller
> Sent: Wednesday, August 23, 2017 12:35 AM
> Subject: Re: [PATCH v2 1/6] fsl/fman: enable FMan Keygen
>
> From: Madalin Bucur <madalin.bucur@nxp.com>
> Date: Tue, 22 Aug 2017 20:31:01 +0300
>
> > /**
> > + * fman_get_keygen
> > + *
> > + * @fman: A Pointer to FMan device
> > + *
> > + * Get the handle to KeyGen module part of FM driver
> > + *
> > + * Return: Handle to KeyGen
> > + */
> > +struct fman_keygen *fman_get_keygen(struct fman *fman)
> > +{
> > + return fman->keygen;
> > +}
> > +EXPORT_SYMBOL(fman_get_keygen);
>
> Please don't do this.
>
> Just directly derefence the pointer in the source code to
> get the keygen.
>
> Thank you.
Hi,
The struct fman is only visible in the fman file, the fman port module uses struct
fman as an opaque pointer, thus this export.
Madalin
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v2 1/6] fsl/fman: enable FMan Keygen David Miller <davem@davemloft.net> - 2017-08-22 23:40 +0200
RE: [PATCH v2 1/6] fsl/fman: enable FMan Keygen Madalin-cristian Bucur <madalin.bucur@nxp.com> - 2017-08-23 06:40 +0200
Re: [PATCH v2 1/6] fsl/fman: enable FMan Keygen David Miller <davem@davemloft.net> - 2017-08-23 06:50 +0200
RE: [PATCH v2 1/6] fsl/fman: enable FMan Keygen Madalin-cristian Bucur <madalin.bucur@nxp.com> - 2017-08-23 07:20 +0200
csiph-web