[PATCH v2 1/2] fault-inject: Restore support for task-independent fault injection

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!news.unit0.net!news.panservice.it!diesel.cu.mi.it!bofh.it!news.nic.it!robomod
From	Bart Van Assche <bart.vanassche@wdc.com>
Newsgroups	linux.kernel
Subject	[PATCH v2 1/2] fault-inject: Restore support for task-independent fault injection
Date	Wed, 23 Aug 2017 01:10:02 +0200
Message-ID	<uhqt4-Iv-17@gated-at.bofh.it> (permalink)
References	<uhqt3-Iv-9@gated-at.bofh.it>
X-Original-To	Andrew Morton <akpm@linux-foundation.org>
X-Ironport-Av	E=Sophos;i="5.41,414,1498492800"; d="scan'208";a="44356361"
X-Mailer	git-send-email 2.14.0
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	78
Organization	linux.* mail to news gateway
X-Original-Cc	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Bart Van Assche <bart.vanassche@wdc.com>, Dmitry Vyukov <dvyukov@google.com>, Akinobu Mita <akinobu.mita@gmail.com>, Michal Hocko <mhocko@kernel.org>
X-Original-Date	Tue, 22 Aug 2017 16:00:42 -0700
X-Original-Message-ID	<20170822230043.9968-2-bart.vanassche@wdc.com>
X-Original-References	<20170822230043.9968-1-bart.vanassche@wdc.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1717884

Show key headers only | View raw

Certain faults should be injected independent of the context
in which these occur. Commit e41d58185f14 made it impossible to
inject faults independent of their context. Restore support for
task-independent fault injection by adding the attribute 'global'.

References: commit e41d58185f14 ("fault-inject: support systematic fault injection")
Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Cc: Dmitry Vyukov <dvyukov@google.com>
Cc: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
---
 include/linux/fault-inject.h | 11 +++++++++--
 lib/fault-inject.c           |  4 +++-
 2 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/include/linux/fault-inject.h b/include/linux/fault-inject.h
index 728d4e0292aa..88dae2f21881 100644
--- a/include/linux/fault-inject.h
+++ b/include/linux/fault-inject.h
@@ -18,6 +18,7 @@ struct fault_attr {
 	atomic_t times;
 	atomic_t space;
 	unsigned long verbose;
+	bool global;
 	bool task_filter;
 	unsigned long stacktrace_depth;
 	unsigned long require_start;
@@ -30,17 +31,23 @@ struct fault_attr {
 	struct dentry *dname;
 };
 
-#define FAULT_ATTR_INITIALIZER {					\
+#define __FAULT_ATTR_INITIALIZER(__global) {				\
 		.interval = 1,						\
 		.times = ATOMIC_INIT(1),				\
 		.require_end = ULONG_MAX,				\
+		.global = (__global),					\
 		.stacktrace_depth = 32,					\
 		.ratelimit_state = RATELIMIT_STATE_INIT_DISABLED,	\
 		.verbose = 2,						\
 		.dname = NULL,						\
 	}
 
-#define DECLARE_FAULT_ATTR(name) struct fault_attr name = FAULT_ATTR_INITIALIZER
+#define FAULT_ATTR_INITIALIZER __FAULT_ATTR_INITIALIZER(false)
+
+#define DECLARE_FAULT_ATTR(name)				\
+	struct fault_attr name = __FAULT_ATTR_INITIALIZER(false)
+#define DECLARE_GLOBAL_FAULT_ATTR(name)				\
+	struct fault_attr name = __FAULT_ATTR_INITIALIZER(true)
 int setup_fault_attr(struct fault_attr *attr, char *str);
 bool should_fail(struct fault_attr *attr, ssize_t size);
 
diff --git a/lib/fault-inject.c b/lib/fault-inject.c
index 7d315fdb9f13..c8f6ef5df3c6 100644
--- a/lib/fault-inject.c
+++ b/lib/fault-inject.c
@@ -107,7 +107,7 @@ static inline bool fail_stacktrace(struct fault_attr *attr)
 
 bool should_fail(struct fault_attr *attr, ssize_t size)
 {
-	if (in_task()) {
+	if (!attr->global && in_task()) {
 		unsigned int fail_nth = READ_ONCE(current->fail_nth);
 
 		if (fail_nth && !WRITE_ONCE(current->fail_nth, fail_nth - 1))
@@ -224,6 +224,8 @@ struct dentry *fault_create_debugfs_attr(const char *name,
 	if (!debugfs_create_u32("verbose_ratelimit_burst", mode, dir,
 				&attr->ratelimit_state.burst))
 		goto fail;
+	if (!debugfs_create_bool("global", mode, dir, &attr->global))
+		goto fail;
 	if (!debugfs_create_bool("task-filter", mode, dir, &attr->task_filter))
 		goto fail;
 
-- 
2.14.0

Thread

[PATCH v2 0/2] Make I/O timeout failure injection again task-independent Bart Van Assche <bart.vanassche@wdc.com> - 2017-08-23 01:10 +0200
  [PATCH v2 1/2] fault-inject: Restore support for task-independent fault injection Bart Van Assche <bart.vanassche@wdc.com> - 2017-08-23 01:10 +0200
    Re: [PATCH v2 1/2] fault-inject: Restore support for task-independent  fault injection Akinobu Mita <akinobu.mita@gmail.com> - 2017-08-23 02:20 +0200
      Re: [PATCH v2 1/2] fault-inject: Restore support for task-independent  fault injection Dmitry Vyukov <dvyukov@google.com> - 2017-08-23 08:10 +0200
      Re: [PATCH v2 1/2] fault-inject: Restore support for task-independent  fault injection Bart Van Assche <Bart.VanAssche@wdc.com> - 2017-08-23 19:40 +0200
  [PATCH v2 2/2] block: Make I/O timeout failure injection again task-independent Bart Van Assche <bart.vanassche@wdc.com> - 2017-08-23 01:10 +0200

csiph-web