Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1718548
| From | Bart Van Assche <Bart.VanAssche@wdc.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 1/2] fault-inject: Restore support for task-independent fault injection |
| Date | 2017-08-23 19:40 +0200 |
| Message-ID | <uhHNg-3vq-7@gated-at.bofh.it> (permalink) |
| References | <uhqt3-Iv-9@gated-at.bofh.it> <uhqt4-Iv-17@gated-at.bofh.it> <uhryO-1AG-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, 2017-08-23 at 09:10 +0900, Akinobu Mita wrote:
> 2017-08-23 8:00 GMT+09:00 Bart Van Assche <bart.vanassche@wdc.com>:
> > Certain faults should be injected independent of the context
> > in which these occur. Commit e41d58185f14 made it impossible to
> > inject faults independent of their context. Restore support for
> > task-independent fault injection by adding the attribute 'global'.
>
> There was a the problem reported by fail-make-request user and the
> problem is introduced by the follow-up patches for systematic
> fault injection.
>
> Please check the commit 9eeb52ae712e ("fault-inject: fix wrong
> should_fail() decision in task context") and see if the problem
> you reported is identical to the commit.
Hello Akinobu,
Since I was using the block layer for-next branch as the basis of my tests,
commit 9eeb52ae712e was not present in the kernel tree used in my tests.
However, with that commit 9eeb52ae712e applied I don't need my two patches
anymore to inject block layer timeout faults successfully. So I'm fine with
dropping my two patches.
Sorry for the noise.
Bart.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 0/2] Make I/O timeout failure injection again task-independent Bart Van Assche <bart.vanassche@wdc.com> - 2017-08-23 01:10 +0200
[PATCH v2 1/2] fault-inject: Restore support for task-independent fault injection Bart Van Assche <bart.vanassche@wdc.com> - 2017-08-23 01:10 +0200
Re: [PATCH v2 1/2] fault-inject: Restore support for task-independent fault injection Akinobu Mita <akinobu.mita@gmail.com> - 2017-08-23 02:20 +0200
Re: [PATCH v2 1/2] fault-inject: Restore support for task-independent fault injection Dmitry Vyukov <dvyukov@google.com> - 2017-08-23 08:10 +0200
Re: [PATCH v2 1/2] fault-inject: Restore support for task-independent fault injection Bart Van Assche <Bart.VanAssche@wdc.com> - 2017-08-23 19:40 +0200
[PATCH v2 2/2] block: Make I/O timeout failure injection again task-independent Bart Van Assche <bart.vanassche@wdc.com> - 2017-08-23 01:10 +0200
csiph-web